juanjo opened the ticket and wrote:

First, IsDepotTypeTile can also work for TRANSPORT_AIR. It doesn't introduce problems. In all calls to this function, IsDepotTypeTile is never called for air transport at the moment.

If that first patch can be accepted, then GetOrderCmdFromTile can be simplified for depots. Unfortunately, there is one line I have problems with. I don't know how to convert a VehicleTypeByte directly into a TransportType type:
if (IsDepotTypeTile(tile, (TransportType)(uint)v->type) && IsTileOwner(tile, _local_company)) {
I would appreciate help from developers in this point.

The rest of the patch are minor codechanges:
If we need the index of a rail waypoint, we don't need the waypoint itself.
To be consistent with the rest of the funciton, user cannot create an order to a waypoint of another company. (Keep in mind buoys have no owner)
Lastly, there is no need to "free" ("do nothing" order) at the end, as the order is already "free" from the beginning.

Attachments

• DetectHangarsInIsDepotTile.diff (0.36 KiB)
• SimplifyGetOrderCmdFromFile.diff (3.76 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/6059