Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals: train gets stuck while entering a depot and path re-reservation occurs #6039

Closed
DorpsGek opened this issue Jun 8, 2014 · 3 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jun 8, 2014

adf88 opened the ticket and wrote:

  1. Send a train to a depot
  2. While the train is entering the depot, initiate path re-reservation e.g. put a PBS on a near track
  3. The train gets sucked

The problem seems to be inside TryPathReserve function, especially the fragment starting at this line:

https://vcs.openttd.org/svn/browser/trunk/src/train_cmd.cpp?rev=26635# L2683

Reservation fails because the depot is already reserved for a train. But it's the same train :) Looks like someone made wrong assumption that "v->track == TRACK_BIT_DEPOT" means that whole train is inside and wants to exit.

Attachments

Reported version: Version?
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6039
@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 8, 2014

adf88 wrote:

I'm not sure about origins of the bug but maybe the depot reservation status should have been already cleared while inside TryPathReserve? Just a thought...


This comment was imported from FlySpray: https://bugs.openttd.org/task/6039#comment13374

@DorpsGek
Copy link
Member Author

andythenorth wrote:

I confirmed this in #6046


This comment was imported from FlySpray: https://bugs.openttd.org/task/6039#comment14667

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

Let's live dangerously sometimes. I can't see this getting fixed. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues
Projects
None yet
Development

No branches or pull requests

4 participants