Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while loading savegame from 0.6 in 1.4 #6032

Closed
DorpsGek opened this issue Jun 1, 2014 · 7 comments
Closed

Crash while loading savegame from 0.6 in 1.4 #6032

DorpsGek opened this issue Jun 1, 2014 · 7 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jun 1, 2014

Eskymak opened the ticket and wrote:

I was trying to open my old savegame and got this strange error. In stable 1.4.0 I got "just" disconnecting train error, but in lates 1.4.1-RC2 error is different.

Crash at: Sun Jun 01 12:39:03 2014
In game date: 2318-03-01 (46)

Crash reason:
Exception: E1212012
Location: 000007FEFD90940D
Message: Assertion failed at line 225 of c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w64bit\src\ground_vehicle.hpp: this->z_pos == GetSlopePixelZ(this->x_pos, this->y_pos)

OpenTTD version:
Version: 1.4.1-RC2 (0)
NewGRF ver: 141067e8
Bits: 64
Endian: little
Dedicated: no
Build date: May 18 2014 18:52:56

Attachments

Reported version: other
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6032
@DorpsGek
Copy link
Member Author

Rubidium wrote:

In stable releases we disable the assertion checks, so it's probably the same issue for both.

When I open the savegame in 0.6.3, let it run for a bit, save it and then open it in 1.4 it seems to work just fine. As a result I'm wondering how/why this particular savegame is deemed to be broken by 1.4.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6032#comment13414

@DorpsGek
Copy link
Member Author

peter1138 wrote:

A maglev on a bridge head at 300x485 is apparently in the wrong place vertically.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6032#comment14374

@DorpsGek
Copy link
Member Author

james1101 wrote:

Workaround:

  1. Pause the game immediately upon loading.
  2. Go to Train 79 (problem train).
  3. Stop the train before it reaches the tile boundary.
  4. Make another train crash into the problem train (Train 79).
  5. To save the train, clone it.
  6. Once the wreck disappears, restore the modified tile(s) to original.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6032#comment14626

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain added needs triage This issue needs further investigation before it becomes actionable bug Something isn't working and removed bug from FlySpray labels Apr 12, 2018
@TrueBrain
Copy link
Member

I would like to know if this was a bug in 0.6, that got fixed between 0.6 and 1.4, and 1.4 just triggers on an old bug? (where the savegame is just unlucky). Or is this just a one-off issue.

@TrueBrain TrueBrain changed the title Crash: loading savegame [1.4.1-RC2] Crash: loading savegame from 0.6 in 1.4 Apr 12, 2018
@TrueBrain TrueBrain changed the title Crash: loading savegame from 0.6 in 1.4 Crash while loading savegame from 0.6 in 1.4 Apr 12, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@James103
Copy link
Contributor

I can still reproduce this bug by loading the attached "EskymakTrans2318.sav" in the original post for this thread (OTTD 1.8.0, Win 7 Ultimate), but the error message is different ("Disconnecting train" instead of "Assertion failed at ...").

Attached crash files

@nielsmh
Copy link
Contributor

nielsmh commented Dec 29, 2018

This is a data error in a singular save file. Crashing the train involved, as james1101 describes on 2017-08-24, and just letting the game run, causes no further errors. Unless someone can reproduce this error with different save files (produced by versions from the same era) this is not a bug.

@nielsmh nielsmh closed this as completed Dec 29, 2018
@James103
Copy link
Contributor

Workaround (2019-05-16 master):

  1. Load and immediately pause the savegame.
  2. Scroll viewport to Train 79's location.
  3. Demolish the two tiles surrounding the train at (300,480) and (300,486).
  4. Build a southeast facing Maglev depot at (300,480).
  5. Reverse (turn around) train 79 and send it to depot.
  6. Save the game.
  7. Run the game one tick. This will crash the game due to invalid vertical positioning at the train's head. Make sure to do an emergency save as well.
  8. Restart the game and load the emergency savegame. Make sure to save the game there as well.
  9. Unpause the game. The game will warn that unpausing can crash OpenTTD. Ignore that warning.
  10. Wait until the train is completely inside the depot. In the meantime, rebuild the junction that was directly southeast of the bridge at (300,486).
  11. Start the train back up (if it stopped inside the depot).
  12. Once the train has left the depot, demolish the depot and replace it with the original rail tile.

Or load this save game: Eskymak Trans (workaround 1.8.0+).sav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable
Projects
None yet
Development

No branches or pull requests

5 participants