Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adminport packet order changed unintentionally #6025

Closed
DorpsGek opened this issue May 24, 2014 · 2 comments
Closed

Adminport packet order changed unintentionally #6025

DorpsGek opened this issue May 24, 2014 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Taede opened the ticket and wrote:

As of r26576, there has been a slight (unintended?) change of behaviour on the admin port wrt to company-creation.

Previous behaviour was: send packet containing info about new company, followed by packet where a client joins aforementioned company.
New behaviour: send a packet informing that client has joined company, then send info about the company.

As a result, when a player creates and joins a company, the admin client may not yet know about the company in case it wants to do something with this information.

Attached diff reverts back to the old behaviour, without re-introducing the original bug (fs# 6003)

Attachments

Reported version: other
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6025
@DorpsGek
Copy link
Member Author

Taede wrote:

used spaces instead of tabs, correct patch now included

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6025#comment13341

@DorpsGek
Copy link
Member Author

planetmaker closed the ticket.

Reason for closing: Implemented

In r26616. Thanks for the patch.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6025

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Network patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant