Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: make refit cost depend on vehicle´s purchase price #6023

Closed
DorpsGek opened this issue May 23, 2014 · 3 comments
Closed

Proposal: make refit cost depend on vehicle´s purchase price #6023

DorpsGek opened this issue May 23, 2014 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

mb opened the ticket and wrote:

Make refit cost depend on the vehicle´s purchase price, instead of the (fixed) purchase price cost base for that particular vehicle type. This would automatically give different refit costs for different vehicles (fixed ratio), without having to use the refit cost callback in every situation.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6023
@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 5, 2014

Pikka wrote:

I'm baffled. Why do you have to use the callback "in every situation" instead of just setting the refit cost property? Can you give more detail, or examples of what the problem is?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6023#comment13366

@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 5, 2014

mb wrote:

I'm baffled. Why do you have to use the callback "in every situation" instead of just
setting the refit cost property? Can you give more detail, or examples of what the problem is?

As I wrote. Refit cost depends on the price cost base for a particular vehicle of the same "feature", e.g. "ship" (only for "trains" there´s a distinction between locomotive and coach/wagon). Hence it´s all the same for every "type" of ship (giant oil tanker, small fishing boat). Which might not fit the ideas of newgrf developers (most of them would use a callback to get around it in this situation).

But it would be far easier (and would help to avoid the callback) by making the refit cost depend on the purchase price (different per vehicle) than on the price cost base (fixed for all vehicles of the same "feature").

HTH


This comment was imported from FlySpray: https://bugs.openttd.org/task/6023#comment13367

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

The refit cost cb exists and can solve this. IMHO, we have enough places with multiple ways to accomplish same goal, I'd rather not add more.

Flyspray clean up, so closing this. Discuss in irc if you think I should reopen.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6023

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs enhancement labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant