Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about fast planes on small airports #6009

Closed
DorpsGek opened this issue May 6, 2014 · 5 comments
Closed

Warn about fast planes on small airports #6009

DorpsGek opened this issue May 6, 2014 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented May 6, 2014

3298 opened the ticket and wrote:

A few months ago Simons Mith collected a list of UI suggestions (http://www.tt-forums.net/viewtopic.php?f=32&t=69835). This patch addresses problem 5.9.0 on that list: there is no UI feedback for fast planes ordered to land on small airports. With this patch an additional news message is inserted into the check for problems in order lists.
The check for a fast plane on a small airport has been inserted into the else-branch of the check for stations without the necessary facilities so we can be sure that the station actually has an airport facility once we know that the vehicle is a plane. The new check also includes "&& problem_type == -1" to ensure previously collected more severe warnings (e.g. invalid stations) are not overwritten.
There are a few magic numbers floating around in that function, and it only allows one warning per vehicle. Should I fix that as well?

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6009
@DorpsGek
Copy link
Member Author

DorpsGek commented May 6, 2014

planetmaker wrote:

Only checks for void orders and invalid stations are done prior to this - too few orders and duplicate entries after this. Yet this sort order is ok for me.

I'd go for a clearer warning message, though, which explicitly tells about the too short landing strip.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6009#comment13297

@DorpsGek
Copy link
Member Author

DorpsGek commented May 6, 2014

3298 wrote:

Wrt. message priorities: I'm not too sure whether this one or "too few orders" should have higher priority, but other than that, a fast plane on a small airport should have a low priority. After all, the plane can use the airport (okay, with a risk), so the order is not as pointless as e.g. one with a station without any landing strip.
Wrt. message text: "{VEHICLE} has a too small airport in its orders" sounded weird to me, so I substituted "too small" for "unsuitable". I undid that in the attached version. I'm still not satisfied because now it feels like we're telling the user that the plane cannot land somewhere at all. If you have a better text, I assume you know how to deal with language files. ;)
Something else I forgot: if _settings_game.vehicle.plane_crashes is 0, not only the random crashes, but also the fast-plane-on-small-airport crashes are disabled. The warning would have triggered still, so I inserted the missing check for that in the attached version.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6009#comment13298

@DorpsGek
Copy link
Member Author

DorpsGek commented May 6, 2014

3298 wrote:

Crap, uploaded the old version again, and I still do not know how to edit comments (if that's possible at all)... let's try again.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6009#comment13299

@DorpsGek
Copy link
Member Author

DorpsGek commented May 6, 2014

planetmaker wrote:

Thanks for the patch and the update, I missed that setting for no crashes, too :)
You missed the place where the warnings are cleared in DeleteOrderWarnings (see r26566).

To answer your other question: unless you're an admin of the bug tracker you cannot edit entries. Amending new versions to the tracker is quite fine


This comment was imported from FlySpray: https://bugs.openttd.org/task/6009#comment13300

@DorpsGek
Copy link
Member Author

DorpsGek commented May 6, 2014

planetmaker closed the ticket.

Reason for closing: Implemented

In r26566


This comment was imported from FlySpray: https://bugs.openttd.org/task/6009

@DorpsGek DorpsGek closed this as completed May 6, 2014
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant