Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timetable: vehicles no longer wait in stations #6006

Closed
DorpsGek opened this issue May 3, 2014 · 6 comments
Closed

Timetable: vehicles no longer wait in stations #6006

DorpsGek opened this issue May 3, 2014 · 6 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues

Comments

@DorpsGek
Copy link
Member

DorpsGek commented May 3, 2014

sph opened the ticket and wrote:

Steps to reproduce:

  1. Build small track with two stations
  2. Buy train, let it autofill
  3. Set both station wait times to 10 days.

The wait time in the timetable is ignored and the vehicle departs immediately when it's done loading (which updates the scheduled times in the timetable). This not only makes timetables useless but also permanently ruins (previously) correct ones.

I've done some debug outputting and vehicle's current_order->wait_time outputs as 0 (while the wait_time is non-zero in the timetable gui). However, I haven't yet discovered why this happens.

This bug was introduced in (svn r26547) -Codechange: Collect order travel and wait times independent of timetables
The previous commit works fine.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6006
@DorpsGek
Copy link
Member Author

DorpsGek commented May 3, 2014

Alberth wrote:

Sounds like the the train is late. In that case it will not wait, but instead depart immediately to catch up.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6006#comment13277

@DorpsGek
Copy link
Member Author

DorpsGek commented May 3, 2014

sph wrote:

No it's not. I'll upload a savegame. Notice how the train's timetable updates at every visit, it simply ignores the wait time of 10 days. This is not the case in an earlier commit.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6006#comment13278

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

ulfhermann/openttd@68a1d97 should fix it.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6006#comment13309

@DorpsGek
Copy link
Member Author

3298 wrote:

This issue seems to be not fixed entirely. Watch the timetable of the only vehicle in the attached save (a train with the orders: go to forest, go to sawmill, go to depot for servicing). The service interval is just over, so this time the train will go to the depot (instead of skipping the order like vehicles do on such orders when they need no service yet), which will set the travel time for that order (was 1 day, timetabled) to 10 days, not timetabled.
Edit (yes, finally found such a button...): Forgot to mention this is on r26588.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6006#comment13328

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

Yes, that's true. current_order becomes OT_DUMMY when the vehicle enters the depot in vehicle.cpp:1407 and then UpdateVehicleTimetable() doesn't see that it's timetabled.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6006#comment13329

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
@TrueBrain TrueBrain added bug Something isn't working and removed bug from FlySpray labels Apr 13, 2018
@andythenorth andythenorth added stale Stale issues and removed Timetables labels Jan 5, 2019
@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues
Projects
None yet
Development

No branches or pull requests

4 participants