Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash during vehicle unload #5995

Closed
DorpsGek opened this issue Apr 27, 2014 · 4 comments
Closed

Crash during vehicle unload #5995

DorpsGek opened this issue Apr 27, 2014 · 4 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues

Comments

@DorpsGek
Copy link
Member

JamesRowden opened the ticket and wrote:

The crash files are attached.

Attachments

Reported version: 1.4.0
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/5995
@DorpsGek
Copy link
Member Author

frosch wrote:

Information from crash.dmp:
012f36c 0043bc58 5f544f4e 43414552 20444548 openttd!abort+0x10 [f:\dd\vctools\crt_bld\self_x86\crt\src\abort.c @ 74]
0012f574 00405468 00e887a8 00000113 00eb7580 openttd!error+0x40 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\openttd.cpp @ 122]
0012f5a0 00407ab7 0d200b88 00000005 00000015 openttd!VehicleCargoList::Append+0xb7 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\cargopacket.cpp @ 267]
0012f5f0 004074c8 0d196e84 0000003b 0000fffd openttd!StationCargoList::ShiftCargo+0xa5 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\cargopacket.cpp @ 725]
0012f624 004063e9 0d196e7c fffffffd 00000001 openttd!StationCargoList::ShiftCargo+0xc8 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\cargopacket.cpp @ 754]
0012f674 00411787 0d196e7c 00000015 0012f630 openttd!StationCargoList::Reserve+0x7f [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\cargopacket.cpp @ 826]
0012f6bc 00412265 0d196ca8 0012f6dc 003bfffd openttd!ReserveConsist+0x104 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\economy.cpp @ 1330]
0012f7bc 00412c14 0012f6dc 00000000 0000003e openttd!LoadUnloadVehicle+0xf3 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\economy.cpp @ 1461]
0012f7d8 00456c40 00000000 001e9694 00000000 openttd!LoadUnloadStation+0x74 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\economy.cpp @ 1781]
0012f880 0043e3f8 001e9694 00000000 00f55782 openttd!CallVehicleTicks+0x59 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\vehicle.cpp @ 879]
0012f9bc 0043e5fd 7627a256 00000000 005bcfec openttd!StateGameLoop+0x12d [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\openttd.cpp @ 1389]
0012f9c8 005bcfec 00000001 00000000 0012fde0 openttd!GameLoop+0xea [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\openttd.cpp @ 1489]
0012fa10 0043d57d 0139da18 0012fdf8 7ffda000 openttd!VideoDriver_Win32::MainLoop+0x2f8 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\video\win32_v.cpp @ 1290]
0012fde0 005bf307 00000001 0012fdf8 00000000 openttd!openttd_main+0x10cf [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\openttd.cpp @ 871]
0012fef8 00691779 00400000 00000000 01551fff openttd!WinMain+0x7a [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\os\windows\win32.cpp @ 452]


This comment was imported from FlySpray: https://bugs.openttd.org/task/5995#comment13260

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

From the crash.sav it seems a vehicle has somehow managed to unload more cargo than it had so that the MTA_KEEP count underflowed. Like that the counts are still "consistent" with each other but you can't get to the MTA_LOAD count anymore by adding up the packet counts. This is then how it exits that loop without adding the packet.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5995#comment13310

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

Another interesting fact: The vehicle in question station-refits "to available cargo" at every single stop. As that does a cargo.Truncate(), which in turn assumes all cargo is MTA_KEEP and just subtracts from that I currently suspect the bug is somewhere around there.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5995#comment13312

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain changed the title Crash: with 'Exception: E1212012' Crash during vehicle unload Apr 12, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues
Projects
None yet
Development

No branches or pull requests

4 participants