Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong capacity of the default cargo for planes (first livery) #5960

Closed
DorpsGek opened this issue Mar 31, 2014 · 3 comments
Closed

Wrong capacity of the default cargo for planes (first livery) #5960

DorpsGek opened this issue Mar 31, 2014 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

George opened the ticket and wrote:

R26438

test in a Arctic game, default cargoes
Default cargo is gold, capacity is 30 for the first livery, 118 (correct) for the second.

[22:23:17] http://dev.openttdcoop.org/projects/worldairlinersset/repository/revisions/6c25b335b49e/entry/src/gfx/Airbus/A300/A300-600F/A300-600F.pnml
[22:23:41] I cant make cargo plane to have correct capacity for default cargo
[22:24:15] In my test game (arctic, default industries and cargoes) default cargo is GOLD
[22:24:20] do you consider cargo size in your calculation?
[22:24:45] it has 30 bags capacity for the first livery and 118 for the others
[22:25:27] as you can see in the code above, I specify it regardles livery
[22:26:06] But the first livery of the first cargo is default capacity divided by 4
[22:26:25] But it should be a CB result instead
[22:28:13] sounds like an issue with misc flag 5: http://newgrf-specs.tt-wiki.net/wiki/VehicleRefitting
[22:28:27] and as to what is default cargo (which is passengers?)
[22:29:40] what passengers if it is a cargo plane?
[22:30:26] not sure such thing can exist
[22:31:47] And what should I do?
[22:32:10] Do you mean I need to set AIRCRAFT_FLAG_AUTOREFIT flag? But why?
[22:34:55] I don't know yet what is going on and why
[22:36:03] I've hardly ever looked at how aircraft work
[22:36:13] As a test I've added PASS as default cargo while mail capacity is set to 0
[22:36:24] and a bug remains
[22:37:24] (default cargo is still gold)
[22:38:05] not passengers?
[22:39:39] yes
[22:39:47] not passengers
[22:40:02] GOLD is the first cargo in the translation table
[22:40:29] and i suppose because of that is taken as default
[22:40:48] might be the case
[22:40:55] and default_cargo_type is not specified for planes
[22:41:09] BTW why not?

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5960
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 1, 2014

George wrote:

Note.
Changing CTT to have PASS the first cargo fixes the issue, but that is only a way to overcome a bug.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5960#comment13189

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 1, 2014

George wrote:

How to reproduce:
Download WAS push 44 (https://jenkins.openttdcoop.org/job/worldairlinersset/44/)
start a new game in arctic
Set current year to 2000
Build A300-600F (for cargo)
Look at gold capacity on both the liveries. Should be 118, but first one is 30 (=122/4)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5960#comment13190

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Implemented

Message from george: l... - as I can test in r27876 A300-600F in WAS it works correctly. So, the problem was solved with some change


This comment was imported from FlySpray: https://bugs.openttd.org/task/5960

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant