FS#595 - Sort by max cargo rating does not sort correctly

Attached to Project: OpenTTD
Opened by KeeperOfTheSoul (KeeperOfTheSoul) - Sunday, 04 February 2007, 23:51 GMT
Type Bug
Category Interface
Status Closed
Assigned To Celestar (Celestar)
Operating System All
Severity Medium
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When sorting by max cargo rating, for some reason stations with lower max ratings can appear after stations with higher max ratings when sorting ascending, the reverse is true when sorting descending. (r8591)
This task depends upon

Closed by  Celestar (Celestar)
Thursday, 08 March 2007, 12:26 GMT
Reason for closing:  Fixed
Comment by KeeperOfTheSoul (KeeperOfTheSoul) - Monday, 05 February 2007, 00:20 GMT
Ah, it may be that it is only considering stations which currently have cargo waiting. If so I still consider this incorrect behaviour as it means those stations with out cargo currently waiting just get ignored and sorted as if they were all the same. Which is confusing if you are looking for stations that are over/under performing.
Comment by KeeperOfTheSoul (KeeperOfTheSoul) - Monday, 05 February 2007, 19:17 GMT
Ah, I've located it. The sorting is only considering the ratings from stations which have cargo waiting, whilst the behaviour I was expecting was for it to consider all ratings that are shown in the station's ratings list. This is currently based upon enroute_from != INVALID_STATION, changing the criteria to this produces the results I was expecting to see.