Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by max cargo rating does not sort correctly #595

Closed
DorpsGek opened this issue Feb 5, 2007 · 3 comments
Closed

Sort by max cargo rating does not sort correctly #595

DorpsGek opened this issue Feb 5, 2007 · 3 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 5, 2007

KeeperOfTheSoul opened the ticket and wrote:

When sorting by max cargo rating, for some reason stations with lower max ratings can appear after stations with higher max ratings when sorting ascending, the reverse is true when sorting descending. (r8591)

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/595
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 5, 2007

KeeperOfTheSoul wrote:

Ah, it may be that it is only considering stations which currently have cargo waiting. If so I still consider this incorrect behaviour as it means those stations with out cargo currently waiting just get ignored and sorted as if they were all the same. Which is confusing if you are looking for stations that are over/under performing.

This comment was imported from FlySpray: https://bugs.openttd.org/task/595#comment884

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 5, 2007

KeeperOfTheSoul wrote:

Ah, I've located it. The sorting is only considering the ratings from stations which have cargo waiting, whilst the behaviour I was expecting was for it to consider all ratings that are shown in the station's ratings list. This is currently based upon enroute_from != INVALID_STATION, changing the criteria to this produces the results I was expecting to see.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/595#comment886

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2007

Celestar closed the ticket.

Reason for closing: Fixed

This comment was imported from FlySpray: https://bugs.openttd.org/task/595

@DorpsGek DorpsGek closed this as completed Mar 8, 2007
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
@DorpsGek DorpsGek mentioned this issue Apr 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek