Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refit costs are not running costs #5938

Closed
DorpsGek opened this issue Mar 8, 2014 · 5 comments
Closed

Refit costs are not running costs #5938

DorpsGek opened this issue Mar 8, 2014 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Mar 8, 2014

megaloman opened the ticket and wrote:

How to reproduce:
Refit any vehicle with non-zero cost of refit. For example: 1.4.0-beta4 -> Start new game -> Build new train depot -> Buy new SH'125' -> Refit to any cargo.

Expected behavior:
Company Finances Window -> Costs of refit are included in "New Vehicles".

Actual behavior:
Company Finances Window -> Costs of refit are included in "Running Costs".

Reported version: 1.4.0-beta4
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5938
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2014

Alberth wrote:

What about having refit orders in the regular order list? A train that is 5 years old getting refitted for a different cargo, is that a "new vehicle"?
Also, what if refitting happens in the station itself (ie auto-refit)? The train then never visits the depot (for refitting, at least).


This comment was imported from FlySpray: https://bugs.openttd.org/task/5938#comment13134

@DorpsGek
Copy link
Member Author

EthanG wrote:

I don't agree refit costs should be listed as new vehicle costs, but listing refit costs as running costs is terrible! I've gone off using newgrfs because I tried to work with these listed "running costs" and the numbers just didn't add up. It's so confusing!


This comment was imported from FlySpray: https://bugs.openttd.org/task/5938#comment13173

@DorpsGek
Copy link
Member Author

hafting wrote:

Refit as a "running cost" makes sense in some cases. Using FIRS, I can have a train transporting oil one way and milk on the return trip - using the same tanks. Then there will be a refit cost on every trip - which seems very much like a "running cost" to me.

Ideally, such automatic refitting would be "running costs" and refitting by the player could be "new vehicle cost". Especially if the vehicle has not been used yet.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5938#comment13186

@DorpsGek
Copy link
Member Author

EthanG wrote:

Those are things players can work out for themselves very easily, but if refit is bundled with new vehicle or running costs, they're not so easy to separate are they?

If I sound snippy, there's a reason. Yesterday another program reminded me that reducing the number of different elements in a UI can be a very stupid thing to do, leading to far more confusion than is necessary. The problem in that other program was options which appear related but which obey different rules. This issue OpenTTD is not even a matter of things which seem related, it's just gratuitously trying to reduce the number of lines. Stop being confusing.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5938#comment13188

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

This is not a current goal for OpenTTD. Flyspray clean up, so closing this. Thanks for the suggestion :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5938

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant