Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewGRF inspect window shows wrong station callbacks #5928

Closed
DorpsGek opened this issue Feb 24, 2014 · 1 comment
Closed

NewGRF inspect window shows wrong station callbacks #5928

DorpsGek opened this issue Feb 24, 2014 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

According to NewGRF specification
http://newgrf-specs.tt-wiki.net/wiki/Action0/Stations# Callback_flags_.280B.29
http://newgrf-specs.tt-wiki.net/wiki/Callbacks# Custom_station_layout_.2824.29
and OpenTTD code
http://vcs.openttd.org/svn/browser/trunk/src/station_cmd.cpp?rev=26371# L1296
http://vcs.openttd.org/svn/browser/trunk/src/station_cmd.cpp?rev=26371# L2700
callback
CBID_STATION_SPRITE_LAYOUT (cb 14) has mask (prop 0B) CBM_STATION_SPRITE_LAYOUT (1) and
CBID_STATION_TILE_LAYOUT (cb 24) is "unmasked".

However, the NewGRF inspect window thinks otherwise and shows wrong results (see also the attached image):
http://vcs.openttd.org/svn/browser/trunk/src/table/newgrf_debug_data.h?rev=26371# L100

Fix-patch attached.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5928
@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r26374. Thanks for the patch!


This comment was imported from FlySpray: https://bugs.openttd.org/task/5928

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) NewStations labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant