Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow separate compilation (objdir != srcdir) #5881

Closed
DorpsGek opened this issue Jan 28, 2014 · 3 comments
Closed

Allow separate compilation (objdir != srcdir) #5881

DorpsGek opened this issue Jan 28, 2014 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

dylex opened the ticket and wrote:

The configure/build system as it stands mostly allows separate compliation, when you run configure from a different directory, but fails in subtle ways. In particular, cpu-type detection and bundling fail. This small patch fixes the various issues. It also removes some related excess quoting that ended up un-quoting paths instead of quoting them (""/path/"").

Obviously it is up to you whether you actually want to support this, but if you don't, it would be nice if it did a check during configure and complained if $PWD != $ROOT_DIR.

Attachments

Reported version: trunk
Operating system: UNIX


This issue was imported from FlySpray: https://bugs.openttd.org/task/5881
@DorpsGek
Copy link
Member Author

frosch wrote:

Hmm, it's not that easy with these four:
+ $(Q)cp "$(ROOT_DIR)/bin/baseset/".grf "$(BASESET_DIR)/"
+ $(Q)cp "$(ROOT_DIR)/bin/baseset/"
.obg "$(BASESET_DIR)/"
+ $(Q)cp "$(ROOT_DIR)/bin/baseset/".obs "$(BASESET_DIR)/"
+ $(Q)cp "$(ROOT_DIR)/bin/baseset/"
.obm "$(BASESET_DIR)/"

Depending on whether GRFcodec is installed or not, they are build from (real) sources or taken as it from the repository.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5881#comment12971

@DorpsGek
Copy link
Member Author

dylex wrote:

The readme claims that using grfcodec will "leave the repository in a modified state" and "modify the base file set." One solution then would be to update Makefile.grf.in to make this actually true, and put the files in $ROOT_DIR/bin rather than $BIN_DIR. Alternatively, bundle could copy from $ROOT_DIR and then copy any addition files from $BIN_DIR if they exist, overwriting the originals.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5881#comment12978

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Build system patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
@TrueBrain
Copy link
Member

I do not think it is useful to try to fix the current configuration system with small things like that. It can have unexpected consequences which are hard to oversee.

I think we can better put the effort in switch to CMake, which solves most of this stuff already.

Tnx anyway (5 years late) for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

2 participants