Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _screen_disable_anim #5873

Closed
DorpsGek opened this issue Jan 23, 2014 · 1 comment
Closed

Replace _screen_disable_anim #5873

DorpsGek opened this issue Jan 23, 2014 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

MJP opened the ticket and wrote:

I hesitated to post that since it is a change of almost no importance (say the one who posted #5871 and #5872...).
But I find 32bpp_anim.cpp easier to read this way.

Pros:
- simplified animated blitter code
- 1 global variable less

Cons:
- giant screenshot may take a bit more time
- giant screenshot may use more memory (size of anim_buf)

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5873
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@TrueBrain
Copy link
Member

Although I am not against a patch like this, the cons make me a bit reluctant. Going to close this for now; please create a Pull Request if you feel this still adds to the readability!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

3 participants