Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseset translations atomatically via WebTranslator daemon #5823

Closed
DorpsGek opened this issue Dec 3, 2013 · 7 comments
Closed

Update baseset translations atomatically via WebTranslator daemon #5823

DorpsGek opened this issue Dec 3, 2013 · 7 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 3, 2013

adf88 opened the ticket and wrote:

When some translator alters baseset translations (STR_BASE... strings) ./bin/baseset/.ob files become obsolete until someone gracefully updates them manually. For example, r25799 (WebTranslator) alters Ukrainian strings and r25813 (frosch) fixes .ob* files. This "desynch" is a real pain in the ass for patch makers/maintainers (especially with patch queues). If you are working with such a revision, compilation introduces changes which you don't want in your patch. So you have to watch out and not use certain revisions or revert changes to .ob* files after every compilation or exclude .ob* files from repo and reinclude them later.

Why not update .ob* files automatically? WebTranslator daemon can run strgen while committing changes. Sounds quite simple.

Reported version: Version?
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5823
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2013

adf88 wrote:

Not 'strgen', I meant 'translations.awk'. WebTranslator could run it.

Alternatively, maybe .ob* files should be generated in the same way like language files (by strgen)? Seems better...


This comment was imported from FlySpray: https://bugs.openttd.org/task/5823#comment12812

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2013

frosch wrote:

You can run "configure --without-grfcodec". Then it won't generate those files.

Btw. the samme issue occurs when using differen grfcodec versions, which result in different openttd.grf. So, there is no ultimate fix for this, unless you require a lot of tools for generating stuff.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5823#comment12813

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2013

adf88 wrote:

But I won't be able to add new sprites too...

I believe there is a fix - include .ob generators (md5sum + translations.awk) into the WebTranslator daemon and commit altered .ob files along with src/lang/*.txt files.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5823#comment12814

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 5, 2013

adf88 wrote:

Currently bin/lang/.lng files have "ignored" status. Why not bin/baseset/.ob* files too then? Would it be OK to change their status to "ignored"?


This comment was imported from FlySpray: https://bugs.openttd.org/task/5823#comment12815

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 5, 2013

frosch wrote:

Files can only be ignored, if they are generated during compilation.
Currently this is only the case for linux and if grfcodec is installed.
Someone started on a script for windows, but I do not remember the result.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5823#comment12816

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@andythenorth andythenorth added the needs triage This issue needs further investigation before it becomes actionable label Apr 13, 2018
@andythenorth
Copy link
Contributor

Still an issue since the switch to eints? I assume yes, but assumptions are bad eh.

@TrueBrain TrueBrain added enhancement Issue would be a good enhancement; we accept Pull Requests! and removed enhancement from FlySpray labels Apr 13, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable
Projects
None yet
Development

No branches or pull requests

4 participants