Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading of (stable) titlegame discards NewGRF townnames #5819

Closed
DorpsGek opened this issue Nov 26, 2013 · 4 comments
Closed

Loading of (stable) titlegame discards NewGRF townnames #5819

DorpsGek opened this issue Nov 26, 2013 · 4 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

AloisMahdal opened the ticket and wrote:

Town name sets can sometimes disappear from the drop-down list in
"Game Options", even after the NewGRF has been activated. This
can be observed right after the game is started, the NewGRF being
activated in previous session.

As a workaround, to make the sets appear on the list again, it's
enough to re-visit the NewGRF Settings dialog (no need to re-activate
the NewGRF file).

STR:

  1. Remove/rename ~/.openttd
  2. Run openttd (allow auto-download
    basic GRFs if asked on startup)
  3. Download relevant NewGRF using in-game downloader
  4. Activate names' NewGRF in "NewGRF Settings" dialog
  5. Go to "Game Options" and check that new sets appear on the list
  6. Quit the game and start it again
  7. Go to "Game Options" and review the name set list. You should see
    that the new sets are missing.

If, instead of just checking the list, one of sets is actually selected
in the step 5, opening dialog in step 7 reveals that "undefined string"
placeholder is selected where the name would be expected. In such case,
however, the bug does not seem to have direct effect on gameplay--map
would be created with correct names.

The bug was observed on Debian Jessie amd64, with two NewGRFs (did
not test other ones):

* Japan Set Town Names (ID: 45520C00, adds one set called "Japanese")
japanese_town_names.0.6/jpset_namw.grf

* Japanese City Names (ID: 736C6602,filename `japanese_city_names-1
/jpcities.grf`, adds three sets, "Japanese (English)", "Japanese
(Hiragana)" and "Japanese (Kanji)")

The bug appears in currently latest version 1.3.3-RC2, as well as version
from official Jessie repos (1.3.2-1).

Attachments

Reported version: 1.3.3-RC2
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5819
@DorpsGek
Copy link
Member Author

AloisMahdal wrote:

Adding ~/.openttd folder, stripped of content_download sub-folder to save space.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5819#comment12809

@DorpsGek
Copy link
Member Author

frosch wrote:

Bug seems to be only present in 1.3 branch, not in trunk.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5819#comment12959

@DorpsGek
Copy link
Member Author

frosch wrote:

Bug is triggered by not using the trunk titlegame. Using a savegame with newer savegame version for the title game (as in release branches) causes the GRF configuration to be reset before the townnames are scanned.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5819#comment12960

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 7, 2017

frosch closed the ticket.

Reason for closing: Fixed

in r27772


This comment was imported from FlySpray: https://bugs.openttd.org/task/5819

@DorpsGek DorpsGek closed this as completed Mar 7, 2017
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant