Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildsign with a GSText => assertion failed #5818

Closed
DorpsGek opened this issue Nov 24, 2013 · 3 comments
Closed

Buildsign with a GSText => assertion failed #5818

DorpsGek opened this issue Nov 24, 2013 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

hpfx opened the ticket and wrote:

Hello,
I got a crash trunk r26074, related to GSSign.BuildSign with a GSText (Assertion failed)
see details here : http://www.tt-forums.net/viewtopic.php?f=33&t=69423
how to reproduce is explained in forum post.

Thank you.

Attachments

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/5818
@DorpsGek
Copy link
Member Author

Rubidium wrote:

The usage of colour (control) codes is not allowed in signs. When an user edits them, they could cause a crash. Because of that some code was added to check that, and you triggered that. I've changed it to just remove the colour coding.

That it worked in a previous stable is actually the cause of another crasher bug.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5818#comment12807

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r26093


This comment was imported from FlySpray: https://bugs.openttd.org/task/5818

@DorpsGek
Copy link
Member Author

hpfx wrote:

Hi,
if ottd don't crash on that anymore, that's nice.
and ok, my signs won't look as nice as they looked ;)

But you have to update documentation then : http://nogo.openttd.org/api/trunk/classGSSign.html# 5590419b2d0394795b754c721719cff5

Parameters:
location The place to build the sign.
name The text to place on the sign (can be either a raw string, or a GSText object).

because it's wrote "GSText", someone can try colors.
Thank you,
Regards.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5818#comment12808

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant