Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OS X] 1.3.3 RC1, ` keystorke opens console, but does not close the console #5812

Closed
DorpsGek opened this issue Nov 20, 2013 · 5 comments
Closed
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

JoeSchmoe opened the ticket and wrote:

I had to go through the menu to close the console.

Reported version: 1.3.3-RC1
Operating system: Mac OS X


This issue was imported from FlySpray: https://bugs.openttd.org/task/5812
@DorpsGek
Copy link
Member Author

michi_cc wrote:

Try pressing the key twice to close it if it is a dead key (i.e. creates accents).

If that doesn't help, please provide more details (OS version, keyboard layout etc).


This comment was imported from FlySpray: https://bugs.openttd.org/task/5812#comment12805

@DorpsGek
Copy link
Member Author

andythenorth wrote:

I see this with tilde ~

First press types the stroke, second press closes console


This comment was imported from FlySpray: https://bugs.openttd.org/task/5812#comment12870

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Also presents using § key


This comment was imported from FlySpray: https://bugs.openttd.org/task/5812#comment12871

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

That behaviour was deliberately put in there by michi_cc in r26002. The commit message says:
"-Fix: [OSX] If the console hotkey is a dead key, require two presses to toggle the console, allowing input of accented characters."

If I remove lines 315 and 316 in event.mm the problem goes away, but of course I can't type § or ` in the console then. What it does at the moment is obviously not what the commit message says. Those keys are no dead keys on this computer, meaning that they should close the console on first press. Would that be a real solution, though? Can we be sure that we don't need those keys in the console?


This comment was imported from FlySpray: https://bugs.openttd.org/task/5812#comment13579

@DorpsGek
Copy link
Member Author

fonsinchen closed the ticket.

Reason for closing: Fixed

in r27046


This comment was imported from FlySpray: https://bugs.openttd.org/task/5812

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant