Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on join dedicated server 1.3.3-rc1 #5811

Closed
DorpsGek opened this issue Nov 19, 2013 · 6 comments
Closed

crash on join dedicated server 1.3.3-rc1 #5811

DorpsGek opened this issue Nov 19, 2013 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

twerkhoven opened the ticket and wrote:

Openttd dedicated server, forked to background (command line options -Df), version 1.3.3-RC1 (Linux 32-bit)

This bug only occurs occasionally, and seems to be tied to clients joining the server. The server gets paused (pause_on_join), and then the server hangs. It does not crash, but is completely unresponsive to the point it needs to be killed with the -9 option.

backtrace courtesy of gdb:
# 0 0xb7763420 in __kernel_vsyscall ()
# 1 0xb7658f74 in pthread_join () from /lib/libpthread.so.0
# 2 0x0848ce64 in ThreadObject_pthread::Join (this=0xc189990) at /home/openttd/svn-stable/src/thread/thread_pthread.cpp:51
# 3 0x08405f44 in WaitTillSaved () at /home/openttd/svn-stable/src/saveload/saveload.cpp:2466
# 4 0x083285b3 in ServerNetworkGameSocketHandler::~ServerNetworkGameSocketHandler (this=0x9cb02e0, __in_chrg=) at /home/openttd/svn-stable/src/network/network_server.cpp:244
# 5 0x083291e0 in ServerNetworkGameSocketHandler::~ServerNetworkGameSocketHandler (this=0x9cb02e0, __in_chrg=) at /home/openttd/svn-stable/src/network/network_server.cpp:246
# 6 0x0832ae04 in ServerNetworkGameSocketHandler::CloseConnection (this=0x9cb02e0, status=NETWORK_RECV_STATUS_SERVER_ERROR) at /home/openttd/svn-stable/src/network/network_server.cpp:304
# 7 0x0830885e in NetworkTCPSocketHandler::ReceivePacket (this=0x9cb02e0) at /home/openttd/svn-stable/src/network/core/tcp.cpp:208
# 8 0x08328017 in ServerNetworkGameSocketHandler::ReceivePacket (this=0x9cb02e0) at /home/openttd/svn-stable/src/network/network_server.cpp:256
# 9 0x08309028 in NetworkGameSocketHandler::ReceivePackets (this=0x9cb02e0) at /home/openttd/svn-stable/src/network/core/tcp_game.cpp:143
# 10 0x0831ea38 in TCPListenHandler<ServerNetworkGameSocketHandler, (unsigned char)0, (unsigned char)1>::Receive () at /home/openttd/svn-stable/src/network/core/tcp_listen.h:132
# 11 0x0831d279 in NetworkGameLoop () at /home/openttd/svn-stable/src/network/network.cpp:855
# 12 0x08380eb5 in GameLoop () at /home/openttd/svn-stable/src/openttd.cpp:1426
# 13 0x084d86d8 in VideoDriver_Dedicated::MainLoop (this=0x95d4eb0) at /home/openttd/svn-stable/src/video/dedicated_v.cpp:314
# 14 0x08381b76 in ttd_main (argc=7, argv=0xbfd94c44) at /home/openttd/svn-stable/src/openttd.cpp:848
# 15 0x081d0828 in main (argc=7, argv=0xbfd94c44) at /home/openttd/svn-stable/src/os/unix/unix.cpp:275

Reported version: 1.3.3-RC1
Operating system: Linux


This issue was imported from FlySpray: https://bugs.openttd.org/task/5811
@DorpsGek
Copy link
Member Author

The_Dude wrote:

Maybe not related, but I have lately experience problems with stucked servers and the need for kill -9 too, it was in stable 1.3.2 though.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5811#comment12800

@DorpsGek
Copy link
Member Author

Rubidium wrote:

The 1.3.2 will be totally unrelated. The particular code it's hanging in has been rewritten in 1.3.3-RC1.

I'd also like the stack traces of the other threads, as it looks like it's waiting on another thread.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5811#comment12801

@DorpsGek
Copy link
Member Author

The_Dude wrote:

If you are talking about r26005 (changes in network_server.cpp and its header), it would be it. I backported that fix to 1.3.2 because of increasing number of crashes on client join. I dont have unfortunately any crashlogs or anything, take that just as or confirmation of this bug report.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5811#comment12802

@DorpsGek
Copy link
Member Author

twerkhoven wrote:

Here's a gdb backtrace from all threads:
http://paste.openttdcoop.org/show/2827/


This comment was imported from FlySpray: https://bugs.openttd.org/task/5811#comment12803

@DorpsGek
Copy link
Member Author

Rubidium wrote:

The attached patch probably works, but I haven't tested it very well yet.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5811#comment12804

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r26043


This comment was imported from FlySpray: https://bugs.openttd.org/task/5811

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant