Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT_REACHED triggered at line 1492 strings.cpp #5804

Closed
DorpsGek opened this issue Nov 16, 2013 · 2 comments
Closed

NOT_REACHED triggered at line 1492 strings.cpp #5804

DorpsGek opened this issue Nov 16, 2013 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

krinn opened the ticket and wrote:

As my current implementation doesn't work i'm afraid i couldn't provide a working version of the awards GS, making the savegame provided useless i suppose, i will upload one working when i reach again a "working" state with it.
Alas also just before crashing an AI has also crashed and tooked the console focus and hide my GS output, so i'm not sure when it was triggered :/
Because one thing i'm sure of: the GS trigger it, by displaying message (guess is because of {VEHICLE} in my english.txt)
don't mind the 1.3.3 pathname for version, i have that because i reuse 1.3.2 ebuild to easy add trunk version to portage. As you might see everywhere, it's the trunk r25939
I put a ----> at line 1492 of my strings.cpp source i use (that is just unpack source of the openttd i have compile)
Here's my current english.txt if it could help
And http://dev.openttdcoop.org/projects/gs-awards/repository for awards source, but this is not the version that was in use, i know, kinda useless but i saw the message real later in my console and many changes were made between the crash and when i saw the log, that was running in a hidden desk.
At least i think the screenshot is useful.

  	case SCC_VEHICLE_NAME: { // {VEHICLE}
  		const Vehicle *v = Vehicle::GetIfValid(args->GetInt32(SCC_VEHICLE_NAME));
  		if (v == NULL) break;

  		if (v->name != NULL) {
  			int64 args_array[] = {(uint64)(size_t)v->name};
  			StringParameters tmp_params(args_array);
  			buff = GetStringWithArgs(buff, STR_JUST_RAW_STRING, &tmp_params, last);
  		} else {
  			int64 args_array[] = {v->unitnumber};
  			StringParameters tmp_params(args_array);

  			StringID str;
  			switch (v->type) {
  ----->				default: NOT_REACHED();
  				case VEH_TRAIN:    str = STR_SV_TRAIN_NAME; break;
  				case VEH_ROAD:     str = STR_SV_ROAD_VEHICLE_NAME; break;
  				case VEH_SHIP:     str = STR_SV_SHIP_NAME; break;
  				case VEH_AIRCRAFT: str = STR_SV_AIRCRAFT_NAME; break;
  			}

  			buff = GetStringWithArgs(buff, str, &tmp_params, last);

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5804
@DorpsGek
Copy link
Member Author

Rubidium wrote:

If you look closely at the crash.png, you'll see that the vehicle award for ludricous speed is messed up. Together with the crash log, that makes me conclude that the particular aircraft that got that award has been removed, and replaced by a non-normal vehicle. Most likely vehicle smoke.

So, what used to be not reachable has become reachable via Game Scripts and AIs.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5804#comment12777

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r26006


This comment was imported from FlySpray: https://bugs.openttd.org/task/5804

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant