Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When i connect server/company. can use default password? #5799

Closed
DorpsGek opened this issue Nov 6, 2013 · 8 comments
Closed

When i connect server/company. can use default password? #5799

DorpsGek opened this issue Nov 6, 2013 · 8 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Nov 6, 2013

munhyunsu opened the ticket and wrote:

we connect server, company in multiplayer game.

if that's protected (password) password dialog is up.
then we type password and press ok.

in openttd.cfg. there's 'default_company_pass' and 'server_password'

it can use when we connect server/company. (use default password).

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5799
@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 6, 2013

munhyunsu wrote:

I coding it

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5799#comment12719

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 6, 2013

planetmaker wrote:

The idea is good. The patch can be improved, though:

NetworkNeedCompanyPasswordWindow, NetworkNeedGamePasswordWindow and NetworkNeedMovePasswordWindow are nearly identical in everything. They could and probably should be unified into one by means of a parameter.
The newly-introduced functions need to get doxygen comments as well. All of them :-)

Mind the coding style. You add or remove in a lot of places whitespace:
* Use tabs only for indentation
* Align stuff only with spaces
* Don't add trailing white spaces anywhere
* Don't add or remove lines or insert or remove spaces without reason. If there's reason, better do that in a separate patch.

See http://wiki.openttd.org/Coding_style Ignoring whitespace changes would cut the amount of changed lines into half size and remove a number of hunks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5799#comment12720

@DorpsGek
Copy link
Member Author

munhyunsu wrote:

oh, sorry. i read your comment lately.

Ok, i got it. i will modify & add doxygen comments.
and re-upload.

thank you for interest.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5799#comment12743

@DorpsGek
Copy link
Member Author

munhyunsu wrote:

@ingo von Borstel (planetmaker)
Hello, I have some question.

NetworkNeed[Game/Company/Move]PasswordWindow looks similar. but it's GUI text is different.
ex) Query Window Label.
NWidget(WWT_TEXT, COLOUR_GREY, WID_NNP_LABEL), SetDataTip(STR_NETWORK_NEED_GAME_PASSWORD, STR_NULL) -->> Server Password
NWidget(WWT_TEXT, COLOUR_GREY, WID_NNP_LABEL), SetDataTip(STR_NETWORK_NEED_COMPANY_PASSWORD, STR_NULL) -->> Company Password

so, how can i unified into one?
i think use 'Parameter' for functionally switch.
and use 'Global variable' for GUI Text.
but i hesitant to use global variable.

i need some idea. :D


This comment was imported from FlySpray: https://bugs.openttd.org/task/5799#comment12751

@DorpsGek
Copy link
Member Author

munhyunsu wrote:

@ingo von Borstel (planetmaker)
Hello, I have some question.

NetworkNeed[Game/Company/Move]PasswordWindow looks similar. but it's GUI text is different.
ex) Query Window Label.
NWidget(WWT_TEXT, COLOUR_GREY, WID_NNP_LABEL), SetDataTip(STR_NETWORK_NEED_GAME_PASSWORD, STR_NULL) -->> Server Password
NWidget(WWT_TEXT, COLOUR_GREY, WID_NNP_LABEL), SetDataTip(STR_NETWORK_NEED_COMPANY_PASSWORD, STR_NULL) -->> Company Password

so, how can i unified into one?
i think use 'Parameter' for functionally switch.
and use 'Global variable' for GUI Text.
but i hesitant to use global variable.

i need some idea. :D


This comment was imported from FlySpray: https://bugs.openttd.org/task/5799#comment12752

@DorpsGek
Copy link
Member Author

munhyunsu wrote:

I complete coding thanks to planetmaker :D

three widget is unified one.
and also unified password set window.

result this.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5799#comment12795

@DorpsGek
Copy link
Member Author

munhyunsu wrote:

I modify GUI

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5799#comment12799

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 7, 2018
@TrueBrain
Copy link
Member

I am not a fan of storing passwords in plain text, and I would hate if we continue adding to that. I rather first see we overhaul how we store passwords, before we add more usages.

So sorry, for now, lets now implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants