Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in station_cmd.cpp #5796

Closed
DorpsGek opened this issue Nov 2, 2013 · 4 comments
Closed

Crash in station_cmd.cpp #5796

DorpsGek opened this issue Nov 2, 2013 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Nov 2, 2013

planetmaker opened the ticket and wrote:

via e-mail:

I played the newest nightly version r25935 but the same crash occured also with r25929. The error message in the game says: Assertion failed at line 3420 of ..\src\station_cmd.cpp: to->goods[c].node == it->first. After clicking OK, "Fatal Application Failure" window appears with this report:

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5796
@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 5, 2013

fonsinchen wrote:

For some reason the mapping between nodes and stations is broken there. I'll have a look at the dump when I find the time.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5796#comment12718

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 6, 2013

fonsinchen wrote:

The problem is that the new LinkRefresher (called in station_cmd.cpp:3450) can merge the link graph we're just checking for stale links and invalidate it. That leads to invalid pointers all over the place and triggers the assert. Nasty. I'll find a solution.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5796#comment12721

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 6, 2013

fonsinchen wrote:

This should do. As we're not interested in creating additional links there we may as well forbid the refresher to merge link graphs in that case. I'll think about it for another day and commit it tomorrow if there are no problems with it.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5796#comment12722

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 7, 2013

fonsinchen closed the ticket.

Reason for closing: Fixed

in r25948


This comment was imported from FlySpray: https://bugs.openttd.org/task/5796

@DorpsGek DorpsGek closed this as completed Nov 7, 2013
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Cargodist labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant