Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBS path reservation not always performed #5779

Closed
DorpsGek opened this issue Oct 6, 2013 · 5 comments
Closed

PBS path reservation not always performed #5779

DorpsGek opened this issue Oct 6, 2013 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Oct 6, 2013

RedPoptarts opened the ticket and wrote:

Path Signals are not properly reserving a path.
Two trains are able to reserve the same path, and crash into one another.

My stations are set up with Path Signals.

I have attached a save file that can reproduce the issue.

Train 6 and Train 32 are stopped in the same station.

They leave at approximately the same time, and both encounter their own path signal. Train 32 gets the first path reservation green light and proceeds through the intersection. Train 6 arrives at the other path signal, and also receives a green light, despite the fact that Train 32 is still actively using the intersection. The two trains crash into eachother.

I have seen this behavior happen multiple times on this game that I'm playing. I'm not sure if it's related to some NewGRFs that I'm using (none of them have said they change signal behavior), but from everything that I've read, this is not supposed to happen with Path signals.

Attachments

Reported version: 1.3.2
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/5779
@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 6, 2013

Alberth wrote:

trains 6 and 32 didn't crash when I let it running, but I found another case, with a near-miss.
Watch the train entering from the top-right.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5779#comment12657

@DorpsGek
Copy link
Member Author

Milsa wrote:

Alberth: Train 32 is not using PBS path. Why? There is more such trains.

Is the problem a combination of normal and PBS signals?

This comment was imported from FlySpray: https://bugs.openttd.org/task/5779#comment12683

@DorpsGek
Copy link
Member Author

Alberth wrote:

We would like to know that too, we have no idea what makes that train operate like that. :(

If you turn on highlighting of reserved tracks ( http://wiki.openttd.org/Advanced_Settings/Interface# Show_reserved_tracks ) those trains should be easy to spot. Perhaps you can discover what makes them forget about claiming a path??
Ideally, you would find a case where this happens for the first time, with a savegame from just before it, but that may be very complicated to find.

The only rule with combining normal and PBS signals is that the signals used for entering a block must be all the same, that is, either all normal signals or all PBS signals. I watched for these cases (it's a common mistake that people forget about it), but I didn't see any such cases while I looked into the problem. I didn't check all tracks and all blocks though.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5779#comment12685

@DorpsGek
Copy link
Member Author

RedPoptarts wrote:

The problem seems to be specific to that particular train engine. The rest of my trains in that save file are a different kind of train and have no issues.

I noticed that the engines from the Japanese Shinkansen trainset seem to exhibit this behavior and are involved in crazy crashes where other engines have no issues. That particular train (# 32) (and one other model I have tested, but can't remember since I am at work) exhibit the non-path-claiming behavior.

If you can investigate the code in the NewGRF behind the engine type that is in use by this train (# 32), then I think that would point us in the right direction.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5779#comment12686

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 9, 2013

Rubidium closed the ticket.

Reason for closing: Fixed

In r25961; is also a bug in Beuls' NewGRF as it should make sure that all powered rail types are compatible as well.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5779

@DorpsGek DorpsGek closed this as completed Nov 9, 2013
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek