juanjo wrote:

I forgot to say it was a patch and not a bug. Sorry.
Reported version is trunk.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5746#comment12612

Rubidium wrote:

Fixing spelling in the town name generators can be done. Removing or adding entries to the tables can't be done.

This is due to the fact that town name generators don't generate a name and store that, they get an integer random value which is stored for each town. During the generation of the random values a check is done for duplicate town names. Via some mapping these random values are constructed into the actual town names.

When you add or remove entries, you change the mapping and it becomes possible that what used to be unique town names become duplicate names. As a result we won't allow adding or removing entries in those tables.

Changing the text of the entries is okay since that doesn't generate a different mapping and as such the town names will remain unique.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5746#comment12613

juanjo wrote:

I have corrected the patch. Only fixing spelling is done now.
I keep changing some entries of _name_catalan_1f, "Aigua"->"Pala" (Aigua generates incorrect names) and "Vall"->"Cova" (Vall was repeated twice). Maybe they can be accepted as spelling changes as well.

Attachments

• CatalanTownNames2.diff (2.56 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5746#comment12616

planetmaker closed the ticket.

Reason for closing: Implemented

In r25774 and r25775. Thanks for the patches.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5746