adf88 opened the ticket and wrote:

How to reproduce: start new game with OpenGFX+BigGUI and open some window with a close box (see attached PNG). You can see that the "X" mark is trimmed.

OpenTTD has some special, sprite-based characters (black cross, train icon etc.). Bad things happen if we substitute them. OpenTTD caches text layout (string widths, heights, etc.). But the cache is not being cleared while loading new set of sprites. This cause GetStringBoundingBox return wrong (cached) value if some character of the string is a sprite-based glyph and it's sprite got larger or smaller.

Note that the "X" being trimmed horizontally (look at signal window for example) is separate problem. In OpenGFX+BigGUI, the "X" sprite is oversized in height. OpenTTD takes height ("leading" value) of the font when text is being lay out horizontally. This is expected. Basically this is BigGUI's problem that it defined oversized sprite. Perhaps WWT_CLOSEBOX should use an image, not a text...

Fix attached.

Attachments

• fix-text_layout_cache_not_being_cleared-r25754.diff (0.97 KiB)
• bug.png (11.89 KiB)

Reported version: Version?
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5737