planetmaker wrote:

I like very much what I see here and also in #5735.

One thing I wonder: the [x] button on the top left does not scale with OpenGFX+BigGUI... was that window-specific (I know it behaves badly in other windows, too) or is that a problem to be fixed at a more general level (and out of scope of these patches)?

This comment was imported from FlySpray: https://bugs.openttd.org/task/5733#comment12585

Alberth wrote:

size calculation of sprites in 10 could also be done in Window::OnInit

This comment was imported from FlySpray: https://bugs.openttd.org/task/5733#comment12586

adf88 wrote:

To cache values? I see no need. Each button has it's own sprite - each sprite is asked for it's size exactly one time per window (re)init.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5733#comment12591

adf88 wrote:

OK, maybe not necessarily once :) I updated the patch:
- now it uses OnInit to cache the size
- WD_IMGBTN_XXX and WD_FRAMERECT_XXX constants are used where appropriate (size calculations, sprite offsetting)
- added vertical centring of signal sprites

Attachments

• 10-use-wd-constants-while-offsetting-gui-signal-sprites (0.81 KiB)
• 11-fit-signal-gui-to-signal-sprites (1.84 KiB)
• 20-fit-signal-gui-to-density-text (0.97 KiB)
• 30-center-vertically-signal-gui-sprites (0.78 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5733#comment12592

adf88 wrote:

I investigated the problem of the [x] button, see #5737

This comment was imported from FlySpray: https://bugs.openttd.org/task/5733#comment12599

frosch closed the ticket.

Reason for closing: Implemented

in r25927 to r25929. Thanks for the patches!

This comment was imported from FlySpray: https://bugs.openttd.org/task/5733