Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News history filtering #5709

Closed
DorpsGek opened this issue Aug 15, 2013 · 1 comment
Closed

News history filtering #5709

DorpsGek opened this issue Aug 15, 2013 · 1 comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Wormnest opened the ticket and wrote:

This patch, consisting of 5 hg patches, provides filtering of the news history window based on the way the stations window filters vehicles and cargo.
A new dropdown list is added showing all available types of news and a all news category. The all news category contains all news unfiltered, the other categories will only show the news that is of the selected type.
For news about vehicles and engines there is an additional vehicle type filter to be able to only show vehicles of the types you are interested in.
The same for industries, you can select the producing cargos you want to be shown.

This patch is based on trunk r25721.

Problems/shortcomings:
For industries that produce more than 1 cargo it is currently not possible to only filter on the cargo type that is mentioned in the news item. e.g. when you get a message about livestock production increasing it will both be shown when filtering on livestock and on grain.
Closing industries can't be filtered on cargo type, since they are closing the industry data isn't sent with the news message.

Possible improvements:
An all news types category but with filters for vehicle and cargo types active.
Combine some news type categories since several of them have a very low amount of news.
Combining the industry production news types might make sense to, however then there would have to be another filter added for opening/closing, own industry/ competitor/ unserviced.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5709
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 7, 2018
@andythenorth
Copy link
Contributor

News isn't so important, it's events in the past eh. :)

Filtering meanwhile always has complications (UI, preserving / clearing state, bug reports of missing items due to filters being applied). All resolvable, but takes work to catch it all.

Let's pass on this one. Feel free to re-open if someone is prepared to push this through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants