Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorized message history #5706

Closed
DorpsGek opened this issue Aug 13, 2013 · 7 comments
Closed

Colorized message history #5706

DorpsGek opened this issue Aug 13, 2013 · 7 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

dessaya opened the ticket and wrote:

This patch colorizes the news items given the type of each one.

Bonus: this also implements #5599 - Colorize last day's news in Message History

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5706
@DorpsGek
Copy link
Member Author

Zuu wrote:

With this patch, the contrast for some message types get reduced compare to the current behaviour. Eg you have brown-red on brown background. This makes it harder to actually read what the news messages says.

Another option is to use a new column which shows the news type without lowering the readability of the news text.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5706#comment12519

@DorpsGek
Copy link
Member Author

dessaya wrote:

Yes, I agree about the low contrast.
I'm not too familiar with the code yet, but it seems like the colors are limited to a few options. I would have liked to use a broader palette.
I also tried painting the background black. It kind of fixed the contrast problem, but it clearly looked like a nerdy console. Not nice :)
I'll see if I manage to implement the extra column.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5706#comment12520

@DorpsGek
Copy link
Member Author

dessaya wrote:

How about a dark red background? That's as much as I can manage without getting my hands dirty :P

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5706#comment12542

@DorpsGek
Copy link
Member Author

frosch wrote:

I think colouring text is quite confusing and unreadable. What exactly do you want to achieve with displaying news types differently?
Isn't filtering as in #5709 more useful? (though personally I would consider a textual filter even more useful than weird categories)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5706#comment12546

@DorpsGek
Copy link
Member Author

dessaya wrote:

What I want to achieve is this: I find the newspaper popups annoying and intrusive. So I disable them and I have the news history window always open. And I find that the colouring makes the list actually more readable: I can filter out items that are not interesting to me by glancing at their colour.
So, if more people find this approach useful maybe what we can do is having it disabled by default and include an option in the settings window to enable it.

I wasn't aware of #5709 (it was posted 3 days after this patch). I haven't tried it, but I don't think it would be very useful in my particular use case; ie, when having the news history always open. I don't want to have to do more clicks to find what I want. I want it to be always there and find it quickly at first sight.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5706#comment12553

@DorpsGek
Copy link
Member Author

dessaya wrote:

This version of the patch adds two switches in the settings window (expert), which control the news colouring and the highlighting of the recent messages, respectively.
Both options are disabled by default.

I don't know if this will break old savegames.
Also, I added the strings to english.txt only.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5706#comment12563

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

With ~9 classes of built-in news type, and also the option for GS to generate arbitrary news, it will be hard to make this look good, and to be widely accessible (considering contrast and colour blind issues). Thanks for the patch though.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5706

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant