Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Add: Mirrored relief in RTL mode #5693

Closed
DorpsGek opened this issue Aug 3, 2013 · 2 comments
Closed

-Add: Mirrored relief in RTL mode #5693

DorpsGek opened this issue Aug 3, 2013 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Aug 3, 2013

sbr opened the ticket and wrote:

In LTR mode relief is suggested by simulating a top left light source.
In RTL mode this light source is situated top right.

 -- rtl-mirror_00add-rtl-framerect-relief_c084b548bf88.patch
Make DrawFrameRect() lighten/darken framerect borders depending of the text direction.

 -- rtl-mirror_01add-freetype-rtl-shadowing_c084b548bf88.patch
Adjust the shadow direction of freetype glyphs depending of the text direction.

I not yet found how to adjust the shadow of sprites. Does someone know where I need to look for?

Please find attached these two patches against r25645.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5693
@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 3, 2013

frosch wrote:

The shadow of sprite glyphs is part of the sprite.
Also all GUI sprites are lighted from left to right, so if you want to change the lighting direction you basically have to provide a complete separate base graphics set. Which will also not fit with any NewGRF provided sprites.
So, overall I don't think changing the lighting of the GUI is feasible at all.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5693#comment12483

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up: no obvious route forward for this, so closing. If this offends, discuss with andythenorth in irc. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5693

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant