Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Fix: RTL alignement of strings and icons #5692

Closed
DorpsGek opened this issue Aug 3, 2013 · 2 comments
Closed

-Fix: RTL alignement of strings and icons #5692

DorpsGek opened this issue Aug 3, 2013 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Aug 3, 2013

sbr opened the ticket and wrote:

The following patches adjust some strings/icons alignement when displayed in RTL mode.

-- rtl-alignement_00fix-signlist-none-right-padding_c084b548bf88.patch
In SignListWindow, right pad the 'None' string.

-- rtl-alignement_01fix-companystations-center-all-facilities-string_c084b548bf88.patch
In CompanyStationsWindow, center the string of the all facilities button.

-- rtl-alignement_02fix-buildindustry-right-align-industry-color-icon_c084b548bf88.patch
In BuildIndustryWindow in RTL mode, draw industry color icon at the right.

-- rtl-alignement_03fix-enginelist-vehicle-name-alignement_c084b548bf88.patch
When drawing EngineList in RTL mode, correctly align the engine name and the engine count.

-- rtl-alignement_04fix-buildairportwindow-airport-name-right-padding_c084b548bf88.patch
Right padding of the airport name string should be negative.

-- rtl-alignement_05fix-linkgraphlegendwindow-company-icon-alignement_c084b548bf88.patch
In LinkGraphLegendWindow, center the company icon.

Please find attached these six patches against r25645.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5692
@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 3, 2013

frosch wrote:

03: The correct alignment of numbers is at the right. "(rtl ? SA_LEFT : SA_RIGHT) | SA_FORCE" make no sense (SA_RIGHT would do the same), SA_FORCE is specifically meant to disable RTL influences.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5692#comment12485

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r25731 to r25733. Thanks for the patches


This comment was imported from FlySpray: https://bugs.openttd.org/task/5692

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant