Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Fix: Properly arrange BuildObjectWindow widgets in RTL mode #5686

Closed
DorpsGek opened this issue Jul 31, 2013 · 2 comments
Closed

-Fix: Properly arrange BuildObjectWindow widgets in RTL mode #5686

DorpsGek opened this issue Jul 31, 2013 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

sbr opened the ticket and wrote:

The BuildObjectWindow doesn't display well in RTL mode as could be seen in the attached screenshot.

- nwidgetmatrix_00fix-rtl-base-horizontal-offset_6d154a33bbce.patch
In RTL mode, the base horizontal offset should be right padded by post padding, not by inter padding.

- nwidgetmatrix_01fix-rtl-base-horizontal-offset-without-scrollbar_6d154a33bbce.patch
The base horizontal offset should also be adjusted for RTL mode even if there is no scrollbar.

- nwidgethorizontal_00fix-rtl-right-align-children_6d154a33bbce.patch
When drawing in RTL mode, NWidgetHorizontal should right-align its children.

- buildobjectwindow_00fix-object-class-string-right-padding_6d154a33bbce.patch
Right padding of strings should be negative.

Please find attached these four patches against r25638.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5686
@DorpsGek
Copy link
Member Author

frosch wrote:

Thanks for the patches!

Wrt. 00: While the addition of pip_inter was wrong, adding of pip_post would also have been wrong, since adding of pip_pre was wrong as well. (so actually all pip adding was wrong)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5686#comment12541

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r25726 to r25729


This comment was imported from FlySpray: https://bugs.openttd.org/task/5686

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant