Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trains can stop twice at the same station without moving #5684

Closed
DorpsGek opened this issue Jul 30, 2013 · 6 comments
Closed

Trains can stop twice at the same station without moving #5684

DorpsGek opened this issue Jul 30, 2013 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

fonsinchen opened the ticket and wrote:

You can see that effect in the attached savegame. The implicit orders are deleted after each round at the second stop.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5684
@DorpsGek
Copy link
Member Author

frosch wrote:

Broken by r25495. wtf


This comment was imported from FlySpray: https://bugs.openttd.org/task/5684#comment12463

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

r25495 is a fix for http://bugs.openttd.org/task/5553 . That fix allows trains to stop at other positions on a platform than they're intended to so that you can modify the platform while a train is approaching. Having a train stop at the same station twice in a row, for example with different order modifications, is generally supported. The general idea is that the train has to move out of the station between those stops, though. Furthermore there currently is no way to tell if a train has left the platform it's currently on since it has last stopped. This means we either have to rely on the position of the train on the platform to determine if it has stopped before or we have to introduce a new flag to mean "has already stopped here". I think we could easily do without support for stopping at platforms the player is currently modifying. Failing to move between subsequent stops is worse. The attached diff reverts most of r25495 and restores the old behaviour.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5684#comment12692

@DorpsGek
Copy link
Member Author

Rubidium wrote:

When we revert it, we should amend the known-bugs.txt about this being case. Then we can later simply refer to known-bugs.txt if the to-be-unfixed bug is reported again.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5684#comment12749

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

That is fine for me. I'll update the patch to do that.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5684#comment12758

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

There we go ...

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5684#comment12784

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r26013


This comment was imported from FlySpray: https://bugs.openttd.org/task/5684

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant