Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override behaviour second 18h tile oil rig #5682

Closed
DorpsGek opened this issue Jul 29, 2013 · 7 comments
Closed

Override behaviour second 18h tile oil rig #5682

DorpsGek opened this issue Jul 29, 2013 · 7 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

George opened the ticket and wrote:

r25610

A station from default oil rig (tile 18) accepts cargo even if the industry and its' tiles do not accept cargo.
This station should (as other stations) check, that there are tiles which accept cargo. In case all the tiles do not accept cargo it should accept cargo too.
This causes the following issue for ECS oil rig and ECS fishing ground: passengers are uploaded into water (industry does not accept cargo, while the station does).

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5682
@DorpsGek
Copy link
Member Author

frosch wrote:

There is nothing special about oilrig stations. The behaviour is already like you request.
Use the tile info tool to find the tiles which cause the acceptance. Either your industry is buggy, or there are other tiles nearby.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5682#comment12445

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 5, 2013

George wrote:

As you can see, OIL rig tiles nor oil rig itself does not accept passengers, while the station accepts passengers and a ship unloads passengers.
The station should not accept passengers, because industry tiles do not accept passengers and there is nothing around that can accept anything.

NOTE: a typo in Details text "In case all the tiles do not accept cargo it(station) should NOT accept cargo too."

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5682#comment12494

@DorpsGek
Copy link
Member Author

Rubidium wrote:

There is one tile that still accepts passengers. The other tiles seem to lose their acceptance when the max becomes red.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5682#comment12744

@DorpsGek
Copy link
Member Author

Rubidium wrote:

For an oil rig you need two 18h tiles for it to get the station. One of them remains and that can't be overridden to provide other behaviour. As such, the passenger acceptance of that tile will always remain.

To remedy this there should be some way to override the behaviour of that second 18h tile, or some other way to tell where the station part has to come.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5682#comment12797

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Confirmed - replicated this with FIRS.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5682#comment14509

@DorpsGek
Copy link
Member Author

andythenorth wrote:

I would solve this a little differently.

  1. Leave the oil rig built-in station alone. It's there, and works for the very special case of wanting to route ships and land helicopters on a water-based industry. Be nice if the station grabbed it's name from the industry, but eh.
  2. Provide buoy stations per Water: enhanced buoys #4792, removing the need for industries like fishing grounds to provide a station. Buoy stations would be for ships only, not helicopters. Any requirement to handle helicopters on water could be met in some enhanced airports in future.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5682#comment14636

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 1, 2017

andythenorth closed the ticket.

Reason for closing: Won't implement

The oil-rig station tile has multiple anomalous behaviours, and won't be changed or made more extensible. As per my comment 25th August 2017 here, we should provide buoy stations, or similar, as an alternative to stations built into industries. See #4792 for that.

Flyspray clean up, this one won't be implemented, as issue needs solved differently, so closing. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5682

@DorpsGek DorpsGek closed this as completed Sep 1, 2017
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant