sbr wrote:

- toggle-text-direction_11add-hotkey_3b2f9d049236.patch
This patch add CTRL+ALT+T as hotkey to toggle the text direction.

Please find attached a patch against r25633.

Attachments

• toggle-text-direction_11add-hotkey_3b2f9d049236.patch (1.68 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5680#comment12446

Rubidium wrote:

You could, relatively easily, drop the attached file into the language folder and compile OpenTTD with that. Then you'll have an English "translation" with the RTL bit set.

It will also work in the intro game editor and survive restarts.

Attachments

• english_rtl.txt (0.16 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5680#comment12462

sbr wrote:

I used to have a patch at the start of my patch queue that declared English (US) as RTL.

Adding an 'English (RTL)' language file is clearly less intrusive than my proposition. However it should only be present in the language dropdown if the 'gui.developer' setting is set.

I thought a more general solution, that is not tied to any particular language, could benefit to those who develop/tests the GUI.
Toggling the text direction with the hotkey is really convenient comparing to a language change in the Game Options. As it's protected by the 'gui.developer' setting this feature is hidden to most of the users.

The menu entry + hotkey could easily be added to the scenario editor and only the hotkey to the intro game.
I'm unsure about the persistence of the text direction change.

EDIT: the menu entry is present in the scenario editor, only the hotkey is missing.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5680#comment12464

sbr wrote:

-- toggle-text-direction_00codechange-help-menu-use-dropdown-items_dba5e699d261.patch
States in english.txt that about menu entries doesn't form a range anymore.

-- toggle-text-direction_01change-empty-dropdown-list-item-as-separator_dba5e699d261.patch
Unchanged.

-- toggle-text-direction_02cleanup-remove-unused-straboutmenuseparator-in-all-languages_dba5e699d261.patch
STR_ABOUT_MENU_SEPARATOR was removed from english.txt. Also remove it in all other languages.

-- toggle-text-direction_10add-toggle-text-direction-function_dba5e699d261.patch
Only add the ToggleTextDirection() function to toolbar_gui.cpp.
Declare it in toolbar_gui.h to be able to use it globally.

-- toggle-text-direction_11add-global-hotkey_dba5e699d261.patch
Defines Ctrl+Alt+D (Control Alternative Direction) as a global hotkey to ToggleTextDirection().

-- toggle-text-direction_12add-help-menu-entry_dba5e699d261.patch
Add the menu entry in the About/Help toolbar menu if 'gui.developer' is set.
This is the only patch who depend on the toggle-text-direction_0* patches.

Please find attached these six patches against r25644.

Attachments

• toggle-text-direction_00codechange-help-menu-use-dropdown-items_dba5e699d261.patch (5.25 KiB)
• toggle-text-direction_01change-empty-dropdown-list-item-as-separator_dba5e699d261.patch (1.55 KiB)
• toggle-text-direction_02cleanup-remove-unused-straboutmenuseparator-in-all-languages_dba5e699d261.patch (38.04 KiB)
• toggle-text-direction_10add-toggle-text-direction-function_dba5e699d261.patch (1.16 KiB)
• toggle-text-direction_11add-global-hotkey_dba5e699d261.patch (1.09 KiB)
• toggle-text-direction_12add-help-menu-entry_dba5e699d261.patch (2.10 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5680#comment12465

Alberth wrote:

Adding an 'English (RTL)' language file is clearly less intrusive than my proposition. However it should only be present in the language dropdown if the 'gui.developer' setting is set.

I thought a more general solution, that is not tied to any particular language, could benefit to those who develop/tests the GUI.
Toggling the text direction with the hotkey is really convenient comparing to a language change in the Game Options. As it's protected by the 'gui.developer' setting this feature is hidden to most of the users.

So who is "those who develop/tests the GUI" exactly? In my view, they would be developers only. Such persons have no problems with one extra test-language.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5680#comment12467

sbr wrote:

So who is "those who develop/tests the GUI" exactly?

Less than ten persons I guess.

In my view, they would be developers only. Such persons have no problems with one extra test-language.

Maybe it's just me who'll benefit from the toggle-text-direction feature. It's fine for me to keep it at the start of my patch queues (although I'll certainly remove the help menu entry and only use it with the hotkey). If others want it they could as well import the patches in their development checkouts. Or use the language file provided by Rubidium; probably most of the developers already do that.

This patches responded to a very specific/personal need and the ratio "code maintenance/benefit to users" is clearly unfavorable to their integration; let's close this task.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5680#comment12475

Alberth wrote:

I also once considered to add the RTL english file to OpenTTD. Like your patch, it would be useful for testing. However, then you have this weird additional language that nobody understands or uses.
Your patch is better in the sense that it is hidden from users, but on the other hand, it also means the code is never used, and may become broken without anyone noticing.
This may be one of the areas that is too much edge case to be useful for adding.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5680#comment12476

Alberth closed the ticket.

Reason for closing: Won't implement

Closed by request of the author.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5680