Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply CB 2D when vehicle stop/start at station or stopped/started manually #5669

Closed
DorpsGek opened this issue Jul 26, 2013 · 5 comments
Closed
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

George opened the ticket and wrote:

r25610

For reducing memory usage xUSSR set requires applying CB 2D (Update colour map) when vehicle starts/stops (manually or at station).

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5669
@DorpsGek
Copy link
Member Author

George wrote:

to be more exact. CB 2D should be applied when a train starts unloading at station and when finishes loading at station.
Inside CB 2D it is required to have the possibility to check this status (started unloading / finished loading)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5669#comment12438

@DorpsGek
Copy link
Member Author

George wrote:

[21:46:13] tbh, I read it and don't quite understand description, intention and problem
[21:47:05] Let me explain
[21:47:26] Currently every locomotive is drawn 3 times
[21:48:09] when all lights are off, when main lights are off, secondary are on, and when all of them are on
[21:52:09] it's too brief, at least for me. Explain the problem in more detail, please
[21:52:46] So, as started we have every locomotive drawn several times
[21:53:03] where? Openttd only draws it once
[21:53:16] I know
[21:53:48] And we choose the sprite group to display according to current speed and state
[21:54:47] the difference between these views are several pixels only (lights)
[21:55:17] I made a test and found, that we can have only one sprite group, while lights are drawn with some unused colours
[21:55:30] and do a colour change with CB 2D
[21:55:48] The idea is nice but it has a huge problem
[21:56:05] CB 2D happens every 32 days or in depot
[21:56:30] and you can't use the start/stop variable or speed check?
[21:56:47] I use speed check
[21:56:56] but it does not work
[21:57:08] because CB 2D result is cashed
[21:57:48] so inside CB 2D code I check it, but OTTD does not call CB 2D
[21:58:15] so I need CB 2D happen very often (when speed changes)
[21:59:30] Alternative is to request CB 2D call for the cases when I really change the result (at start|stop)
[21:59:42] but using different sprites is no issue really
[21:59:49] This what I requested in the feature request
[22:00:39] So you say that making the GRF 3 times smaller to save the RAM is USELESS?
[22:01:02] Because OTTD has to load 3 time more sprites


This comment was imported from FlySpray: https://bugs.openttd.org/task/5669#comment12441

@DorpsGek
Copy link
Member Author

George wrote:


This comment was imported from FlySpray: https://bugs.openttd.org/task/5669#comment12442

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 4, 2013

frosch closed the ticket.

Reason for closing: Implemented

in r25648


This comment was imported from FlySpray: https://bugs.openttd.org/task/5669

@DorpsGek DorpsGek closed this as completed Aug 4, 2013
@DorpsGek
Copy link
Member Author

frosch wrote:

The recolouring should now also be updated when leaving a station with r26027.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5669#comment12793

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant