Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix VS 2012 FACILITY_DIRECTMUSIC warning #5663

Closed
DorpsGek opened this issue Jul 21, 2013 · 3 comments
Closed

fix VS 2012 FACILITY_DIRECTMUSIC warning #5663

DorpsGek opened this issue Jul 21, 2013 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

Since some new SDK (not sure which version, VS 2012 installer use it) <winerror.h> contains FACILITY_DIRECTMUSIC macro definition. This macro is also present inside <dmerror.h> (the one from the "handy zip file containing direct music headers") causing a warning. The patch fixes it by undefining FACILITY_DIRECTMUSIC befor including dmusic headers.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5663
@DorpsGek
Copy link
Member Author

adf88 wrote:

Also see my comment here http://bugs.openttd.org/task/5375 (Fix __forceinline in Visual Studio 2012)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5663#comment12431

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@nielsmh
Copy link
Contributor

nielsmh commented May 24, 2018

Either #6787 or #6774 will probably obsolete this.

@michicc
Copy link
Member

michicc commented May 26, 2018

Fixed by #6787.

@michicc michicc closed this as completed May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

4 participants