Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility of companies on graphs is not saved in game #5654

Closed
DorpsGek opened this issue Jul 16, 2013 · 5 comments
Closed

Visibility of companies on graphs is not saved in game #5654

DorpsGek opened this issue Jul 16, 2013 · 5 comments
Labels
bug Something isn't working component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers

Comments

@DorpsGek
Copy link
Member

Kogut opened the ticket and wrote:

As result settings from old, finished game are transferred to the new one, just started what makes no sense.

r25613

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5654
@DorpsGek
Copy link
Member Author

andythenorth wrote:

Didn't verify, but as described, sounds like a bug...feature request.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5654#comment14537

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
@TrueBrain
Copy link
Member

Okay, my parser needed some effort to understand this. No screenshots wasn't helping, and describing a solution rather than the problem neither. So here it goes:

  • Start a game
  • Start an AI
  • Go to any graph with the Key button
  • Select your own company
  • Leave game
  • Load/Start a game
  • Go to any graph with the Key button

Expected:

  • Everything selected again

Found:

  • Remembered setting of last game

That is weird :D

@TrueBrain TrueBrain added good first issue Good for newcomers bug Something isn't working and removed bug from FlySpray labels Apr 14, 2018
@andythenorth
Copy link
Contributor

andythenorth commented Apr 14, 2018

Repro steps attached.

  • I only tested op. profit graph, making assumption all company graphs are affected
  • I only tested new game, making assumption this applies for load as well

Example shows only one company, where toggling would be silly, but imagine it with multiple companies.

5654-1

5654-2

5654-3

@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

GabdaZM added a commit to GabdaZM/OpenTTD that referenced this issue Feb 7, 2019
@andythenorth
Copy link
Contributor

Now fixed in #7191. Thanks!

@nielsmh nielsmh reopened this Feb 8, 2019
@stale stale bot removed the stale Stale issues label Feb 8, 2019
@nielsmh nielsmh closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants