OpenTTD

Tasklist

FS#5646 - SendGameScript adheres to different rules than Receive_ADMIN_GAMESCRIPT

Attached to Project: OpenTTD
Opened by Xaroth Brook (Xaroth) - Thursday, 11 July 2013, 21:55 GMT
Last edited by Ingo von Borstel (planetmaker) - Friday, 12 July 2013, 17:18 GMT
Type Patch
Category Network → Admin
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

In Receive_ADMIN_GAMESCRIPT, we limit the maximum string size of json data we can receive to NETWORK_GAMESCRIPT_JSON_LENGTH , however, in SendGameScript a different limit is set (based off of SEND_MTU) .. this means we can potentially -send- more data than we can ever receive.

Attached patch normalizes this to limit both to NETWORK_GAMESCRIPT_JSON_LENGTH.
This task depends upon

Closed by  Ingo von Borstel (planetmaker)
Friday, 12 July 2013, 17:18 GMT
Reason for closing:  Implemented
Additional comments about closing:  In r25589. Thanks for the patch

Loading...