Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SendGameScript adheres to different rules than Receive_ADMIN_GAMESCRIPT #5646

Closed
DorpsGek opened this issue Jul 11, 2013 · 1 comment
Closed
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Xaroth opened the ticket and wrote:

In Receive_ADMIN_GAMESCRIPT, we limit the maximum string size of json data we can receive to NETWORK_GAMESCRIPT_JSON_LENGTH , however, in SendGameScript a different limit is set (based off of SEND_MTU) .. this means we can potentially -send- more data than we can ever receive.

Attached patch normalizes this to limit both to NETWORK_GAMESCRIPT_JSON_LENGTH.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5646
@DorpsGek
Copy link
Member Author

planetmaker closed the ticket.

Reason for closing: Implemented

In r25589. Thanks for the patch


This comment was imported from FlySpray: https://bugs.openttd.org/task/5646

@DorpsGek DorpsGek added Admin flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant