Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of 3 packets #5643

Closed
DorpsGek opened this issue Jul 10, 2013 · 3 comments
Closed

Addition of 3 packets #5643

DorpsGek opened this issue Jul 10, 2013 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Xaroth opened the ticket and wrote:

As discussed with planetmaker on IRC.

The added patch adds functionality for the following:

  1. It modifies Receive_ADMIN_RCON to send a ADMIN_PACKET_SERVER_RCON_END packet at the end of the command execution; this way clients who send such commands have a clear indicator that that the command has executed, regardless of the amount of lines of output generated. The packet sends the original command as sent so it can be matched by the client.

  2. It adds a PING/PONG system, this way clients have a 'clean' method of determining the connection status (and the responsiveness of the server), and act accordingly (i.e. notify the admins if the server becomes unresponsive for too long)

ADMIN_PACKET_ADMIN_PING is sent by the client; taking an uint32 payload. this payload is then returned by the server in the ADMIN_PACKET_SERVER_PONG response.

As discussed these changes should be backwards compatible (granted old clients ignore unknown packets), and don't require a bump of the protocol version.

Please note that I have not yet got the time to test the validity of the attached patch; I will update this after some tests have been made.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5643
@DorpsGek
Copy link
Member Author

Xaroth wrote:

Added separate patches for the two points mentioned, as they are really different problems.

Note, both are based separately off of a clean trunk checkout.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5643#comment12397

@DorpsGek
Copy link
Member Author

planetmaker closed the ticket.

Reason for closing: Implemented

In r25587 and r25588. Thanks for the patches.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5643

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 3, 2013

xOR wrote:

Thanks dude, great addition, xShunter makes use of both now and it's working like a charm. In the past I had an ugly solution for the ping where I would send the payload to the console using "echo" and parsing it when it returns. Now there finally is a clean solution. Same story for RCON.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5643#comment12474

@DorpsGek DorpsGek added Admin flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek