Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Switching tracks quickly in jukebox #5585

Closed
DorpsGek opened this issue Jun 5, 2013 · 5 comments
Closed

[Windows] Switching tracks quickly in jukebox #5585

DorpsGek opened this issue Jun 5, 2013 · 5 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jun 5, 2013

Brumi opened the ticket and wrote:

If I switch tracks in the jukebox quickly by pressing 'next/previous track' multiple times in a quick succession, the wrong track will start playing. For example, if track 1 is playing, and then I press 'next' two times to play track 3, track 2 will play instead. The bug is present for me with all music sets.

Reported version: 1.3.1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/5585
@DorpsGek
Copy link
Member Author

Phrossi_TTD wrote:

Confirmed, happens to me too.
Proably cause is the game not updating the music quick enough?


This comment was imported from FlySpray: https://bugs.openttd.org/task/5585#comment12310

@DorpsGek
Copy link
Member Author

Rubidium wrote:

I cannot reproduce this on Linux, and there seems to be quite a lot of magic w.r.t. waiting in the Windows music driver, so I suspect it to be Windows only.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5585#comment12403

@DorpsGek
Copy link
Member Author

Jaap wrote:

I could reproduce it on Windows 7 64bit, also with the newest r25939.

It seems that the command to open the song takes too much time. When skipping some songs within a couple of seconds, the action to load the latest song will not be taken while the old song is loading.
I made a patch which compares the current song against the requested song to make sure that the correct song will be loaded finally.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5585#comment12745

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain added patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay bug Something isn't working and removed bug from FlySpray labels Apr 13, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@nielsmh
Copy link
Contributor

nielsmh commented Jun 7, 2018

The above patch is obsolete with the new music drivers on Windows, and the issue needs to be tested again. It should also be tested on non-Windows systems with various drivers.

@nielsmh
Copy link
Contributor

nielsmh commented Jul 1, 2018

Looking at the description of this again, it's seems to have been an artifact of the old MCI-based Win32 music driver, which had the exact issue on newer Windows versions of taking multiple seconds to load each song. The new drivers typically load a song in less than 100 ms so I think the issue can be considered fixed.

@nielsmh nielsmh closed this as completed Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

4 participants