fonsinchen opened the ticket and wrote:

As observed by Rubidium in http://www.tt-forums.net/viewtopic.php?f=33&t=41992&start=2780# p1078917 a vehicle can be left in an overloaded state when it's unloading cargo while at the same time having reserved some cargo and if during that time the station stops accepting the cargo being unloaded. This leads to an integer overflow in a different place and indirectly creates the problem of inflated reservation.

The attached patch makes sure that some reserved cargo is returned if cargo previously scheduled for unloading is kept instead. Additionally it adds an assert in ReserveConsist to make sure the sum of kept and reserved cargo is always <= the vechicles capacity.

Attachments

• overload.diff (1.40 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5583