Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved readability in company finances window #5551

Closed
DorpsGek opened this issue May 18, 2013 · 8 comments
Closed

Improved readability in company finances window #5551

DorpsGek opened this issue May 18, 2013 · 8 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

kvee opened the ticket and wrote:

This patch improves readability in the company finances window by regrouping some values and introducing a separator value in the ExpensesType enum.

Attachments

Reported version: Version?
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5551
@DorpsGek
Copy link
Member Author

Alberth wrote:

Changing the default layout is not an option, in my opinion.
Instead, you should look into adding something so your layout becomes a 3rd way of showing finances.

My second main problem with your patch is that you add yet another permutation of displaying the same numbers. How many of these do we need before we have "enough"?
Personally, I never look at these numbers, the "vehicle has negative income" warning provides sufficient information (and much quicker too) to steer my empires.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5551#comment12223

@DorpsGek
Copy link
Member Author

kvee wrote:

Well, I use this window from time to time and it seems unnecessarily cluttered to me.
The point of this patch is to simply rearrange the values, so that relevant values are next to each other. Seeing as many other windows underwent slight cosmetic changes (always for the better) in the past, while this one never did, I thought this would be a nice, clean way to improve it. Especially given the relatively small code change necessary.

And I agree, no point in adding anything new. This really is precisely about changing the default layout for a better one. If that's not an option, well, there's not much else I can do.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5551#comment12224

@DorpsGek
Copy link
Member Author

NG wrote:

Changing the default layout is not an option, in my opinion.

Personally, I never look at these numbers
If you really don't, why even care? That being said, the optimal solution would probably be switching between a group-by-item view as in this patch and an income-above-expenses view. The standard window is just an awkward mix of both, and could certainly do with some spacing no matter what.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5551#comment12225

@DorpsGek
Copy link
Member Author

Alberth wrote:

Because I know users will get very upset when you change their windows.
But if you don't want my feedback or time to add it, that's ok too.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5551#comment12227

@DorpsGek
Copy link
Member Author

frosch wrote:

Oh well, there is already a setting to choose between two window layouts... and last time people wanted a "formally correct" balance sheet which grouped expenses and income. So, I guess this would need a third value, or other people will complain.

Personally I do not see much use in grouping it per vehicle type. There is no bigger difference between vehicle types than between vehicle groups. And likely profit per group is a lot more interesting, than per vehicle type.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5551#comment12228

@DorpsGek
Copy link
Member Author

andythenorth wrote:

This would actually be my preferred layout. The balance sheet view is 'correct' but kind of tedious, just like a balance sheet in the real world. I prefer to know if each vehicle type is actually making money. But then transfers....or maybe I have 10 vehicles losing money, and 1 making a lot of money? Basically finances window is mostly useless eh?

So dunno if this is worth including. Yet Another Way To Display Finances. Do we have enough fragmented UI options already? :|


This comment was imported from FlySpray: https://bugs.openttd.org/task/5551#comment14529

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2017

andythenorth wrote:

Tested this, compiles on r27910

Finances window opens far too wide for my viewport, with no option to resize.

Will close if no further commentary on this.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5551#comment14726

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 7, 2018
@TrueBrain
Copy link
Member

I think this has been talked about enough to close it up. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants