Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeating Station Costs #5544

Closed
DorpsGek opened this issue May 8, 2013 · 6 comments
Closed

Repeating Station Costs #5544

DorpsGek opened this issue May 8, 2013 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented May 8, 2013

glsurratt opened the ticket and wrote:

OpenTTD ver 1.2.3 recently upgraded to 1.3.0. Both exhibit the same behavior. Running on Windows 8 Pro.

When a station is built, repeated mouse clicks on the station cause the game to charge the cost for building the station again, even though no changes are made to the original station.
Duplicate this problem by building a station in a new game with the $200,000 original loan. Continue clicking on the station. Eventually, the entire amount of the loan is consumed, throwing an error for "Not enough cash."
This additional charge can be incurred even after going and building other items and coming back to the station.

This causes a problem (extra charge) if there is a key-bounce on the mouse where a button is accidentally clicked more than once.

Building a track section over an existing track section throws an error "Can't build railway track here . . . Already built"

Recommend a similar message for station building when no changes are made to the station.

Save game attached.
2 .png files attached.
First shows repeat charges for same station.
Second shows error for trying to build over an existing track.

(Please re-classify this from "Bug" if necessary. I'm not sure if type and category are correct.)

Attachments

Reported version: 1.3.0
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5544
@DorpsGek
Copy link
Member Author

DorpsGek commented May 9, 2013

Alberth wrote:

Interesting edge case. No idea what to do here.

There is a difference between stations and tracks, which becomes clear when you load a station newgrf, like CHIPS.
The latter provides several station tiles of a different colour. You can (and are supposed to be able) overbuild a station so you can replace station tiles with other station tiles.

Your case is an extreme form, where you overbuild the station tiles with the same tiles. Technically, it is perfectly fine to do that. It just looks a bit weird, and may be experienced as unexpected behavior.

With tracks it's different, there are no sets of tracks that you can overbuild. You can upgrade or downgrade to another trackset only.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5544#comment12188

@DorpsGek
Copy link
Member Author

DorpsGek commented May 9, 2013

frosch wrote:

We had this report several times before. While I am too lazy to look up the old FS tasks, it boils down to this:
- When using NewGRF stations it is sometimes intentional to overbuild a station with the same thing again, because it might appear different dependending on the build date, or random factors. Esp. in the latter case the player may want to build the station as often until his favorite layout appears.
- Everytime this "bug" was reported, it was from someone who does not use NewGRF.

So, I think the current behaviour is mostly confusing only to novice players. Thus we might try to only disallow overbuilding for the default stations. Default stations are what new players use, and overbuilding has no effect to them. For NewGRF stations otoh there is an effect, and thus also a good explanation to keep the behaviour.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5544#comment12190

@DorpsGek
Copy link
Member Author

peter1138 wrote:

Alternatively, don't charge for building over an existing station tile.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5544#comment12232

@DorpsGek
Copy link
Member Author

mb wrote:

"Overbuilding" station tiles is in fact a dubious feature (IIRC, it only emerged in TTDPatch as an unforeseen by-product), because it might interfere with pre-defined tile layouts or tiles depending on neighbouring tiles.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5544#comment12233

@DorpsGek
Copy link
Member Author

adf88 wrote:

I started patching this problem some time ago. It was intended to be a part of my "Clipboard" patch. I accomplished the job only for bus/truck stops. Diff attached:

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5544#comment12234

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't fix

Over-building is an established expectation, and is exploited by newgrfs that offer randomised tiles. The solution to charging on extra clicks is to not click multiple times.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5544

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@DorpsGek DorpsGek mentioned this issue Apr 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek