Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo scheduled for unloading is not returned when cancelling the loading process #5543

Closed
DorpsGek opened this issue May 8, 2013 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented May 8, 2013

fonsinchen opened the ticket and wrote:

When a consist leaves a station for whatever reason Vehicle::CancelReservation is called. This method checks if the consist still has cargo reserved for loading and returns that. In the latter case it also resets the counters for cargo to be unloaded or transferred. The logic is obviously not correct. A vehicle can unload or transfer cargo without loading new cargo. Thus the counters should always be reset when cancelling reservations. Normally this is not a problem but in certain special cases, as most likely observed at http://www.tt-forums.net/viewtopic.php?f=33&t=41992&start=2740# p1076344 , the invalid counters can crash the game later on.

The included patch fixes the problem by always resetting the counters.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5543
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r25235. Thanks for the patch


This comment was imported from FlySpray: https://bugs.openttd.org/task/5543

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant