Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: music volume control for the extmidi driver #5499

Closed
DorpsGek opened this issue Mar 10, 2013 · 6 comments
Closed

Audio: music volume control for the extmidi driver #5499

DorpsGek opened this issue Mar 10, 2013 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

sfriebe opened the ticket and wrote:

This patch enables the volume control for the extmidi driver.
It gives the selected volume as parameter to timidity when a new song is started.

Even when it works, it has a few problems:
- It probably only works with timidity.
- The volume only changes when a new song is started, but that is better than no volume control at all.

Reported version: trunk
Operating system: Linux


This issue was imported from FlySpray: https://bugs.openttd.org/task/5499
@DorpsGek
Copy link
Member Author

frosch wrote:

I guess you also had planned to attach a patch file :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5499#comment12080

@DorpsGek
Copy link
Member Author

sfriebe wrote:

Okay, next try. Is there another button except for "browse"?
Edit: Ha, this time it worked. Strange...
Edit2: Or not strange at all. I forgot the summary and after it send me back to add it, the file was forgotten.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5499#comment12081

@DorpsGek
Copy link
Member Author

peter1138 wrote:

It doesn't just only work for timidity, it also prevents other players from working.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5499#comment12084

@DorpsGek
Copy link
Member Author

sfriebe wrote:

Okay, thats a point i haven't thougth about.
It could be solved with defines, but the code does look a bit messy now.
Doing this for all players is not possible, however since timidity is
the default player this construct might be okay.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5499#comment12085

@DorpsGek
Copy link
Member Author

s0r00t wrote:

[redacted, did not read the date correctly]


This comment was imported from FlySpray: https://bugs.openttd.org/task/5499#comment14404

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@andythenorth
Copy link
Contributor

No progress for 5 years, let's say this one's time has passed :) Happy to re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants