FS#5499 - Audio: music volume control for the extmidi driver

Attached to Project: OpenTTD
Opened by Sebastian Friebe (sfriebe) - Sunday, 10 March 2013, 08:54 GMT
Last edited by andythenorth (andythenorth) - Monday, 04 September 2017, 07:04 GMT
Type Feature Request
Category Core
Status With patch
Assigned To No-one
Operating System Linux
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


This patch enables the volume control for the extmidi driver.
It gives the selected volume as parameter to timidity when a new song is started.

Even when it works, it has a few problems:
- It probably only works with timidity.
- The volume only changes when a new song is started, but that is better than no volume control at all.
This task depends upon

Comment by frosch (frosch) - Sunday, 10 March 2013, 10:00 GMT
I guess you also had planned to attach a patch file :)
Comment by Sebastian Friebe (sfriebe) - Sunday, 10 March 2013, 10:03 GMT
Okay, next try. Is there another button except for "browse"?
Edit: Ha, this time it worked. Strange...
Edit2: Or not strange at all. I forgot the summary and after it send me back to add it, the file was forgotten.
Comment by Peter Nelson (peter1138) - Tuesday, 12 March 2013, 07:33 GMT
It doesn't just only work for timidity, it also prevents other players from working.
Comment by Sebastian Friebe (sfriebe) - Tuesday, 12 March 2013, 08:24 GMT
Okay, thats a point i haven't thougth about.
It could be solved with defines, but the code does look a bit messy now.
Doing this for all players is not possible, however since timidity is
the default player this construct might be okay.
Comment by Hugo COURTIAL (s0r00t) - Wednesday, 29 March 2017, 19:37 GMT
[redacted, did not read the date correctly]