FS#5495 - Vehicles waste a tick trying to unload even though they don't have cargo to unload

Attached to Project: OpenTTD
Opened by fonsinchen (fonsinchen) - Monday, 04 March 2013, 10:28 GMT
Last edited by Remko Bijker (Rubidium) - Saturday, 06 April 2013, 18:57 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


In PrepareUnload we're setting the VF_CARGO_UNLOADING flag regardless of the result the staging algorithm generated. So if the staging algorithm decides a vehicle will keep all its cargo and not unload anything the flag is still set and in the first unloading tick the vehicle does nothing. The patch fixes that.
This task depends upon

Closed by  Remko Bijker (Rubidium)
Saturday, 06 April 2013, 18:57 GMT
Reason for closing:  Implemented
Additional comments about closing:  In r25156. Thanks for the patch