Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTTD failes to build from source with gcc-4.8 #5489

Closed
DorpsGek opened this issue Feb 26, 2013 · 3 comments
Closed

OpenTTD failes to build from source with gcc-4.8 #5489

DorpsGek opened this issue Feb 26, 2013 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

erikjanp opened the ticket and wrote:

Compiling OpenTTD from trunk with a gcc-4.8-20130210-snapshot gives an error:
[DEP] ogfx1_base.gfx.dep
Illegal character '# ' at "", line 1

Gcc-4.8 automatically includes an extra header <stdc-predef.h>, which causes the problem.

Attached patches fix this problem, for OpenTTD and OpenGFX.

See https://bugzilla.redhat.com/show_bug.cgi?id=906517# c6 for a similar case and the solution in comment # 8.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5489
@DorpsGek
Copy link
Member Author

erikjanp wrote:

And here are the patches

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5489#comment12055

@DorpsGek
Copy link
Member Author

Rubidium wrote:

I was notified of this issue via someone else before seeing this patch. OpenTTD now uses -nostdinc which seems to be having the same effect as -ffreestanding.

In my man page of cpp -nostdinc is mentioned and -ffreestanding is not, so I reckon -nostdinc is the safer option w.r.t. compatability. However, I am not completely sure about it.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5489#comment12056

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r25050

This comment was imported from FlySpray: https://bugs.openttd.org/task/5489

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Build system patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek