Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash while paused after clicking status bar #5486

Closed
DorpsGek opened this issue Feb 24, 2013 · 3 comments
Closed

Crash while paused after clicking status bar #5486

DorpsGek opened this issue Feb 24, 2013 · 3 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

k0mpjut0r opened the ticket and wrote:

I was playing a game with CityBuilder (v70) enabled. After the gamescript ended (4 years I guess), the game was paused and showed a message. I was unable to unpause the game using the first button (pause), so I clicked on the status bar, which said PAUSED, and the game crashed. I saved the game beforehand (already paused), and I was able to repeat the crash several times by clicking the bottom status bar.

Attachments

Reported version: 1.3.0-RC1
Operating system: Linux

This issue was imported from FlySpray: https://bugs.openttd.org/task/5486
@DorpsGek
Copy link
Member Author

Pikka wrote:

"CityBuilder (v70)" is this gamescript: https://www.tt-forums.net/viewtopic.php?f=65&t=62868

This comment was imported from FlySpray: https://bugs.openttd.org/task/5486#comment12043

@DorpsGek
Copy link
Member Author

3298 wrote:

I experienced a probably related crash with NoCarGoal in new games. The NoCarGoal script creates a news item at game start, and when clicking the status bar (which is supposed to show the last news item) before unpausing the game (I always play with pause on new game), the game crashes.
I tracked it down to the _current_news variable in news_gui.cpp, which is NULL while the ShowLastNewsMessage() function tries to dereference it. My suggested fix is to insert a line after this:
else if (_forced_news == NULL) {
containing this:
if (_current_news == NULL) _current_news = _latest_news;
At least for me this change prevents the crash.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5486#comment12088

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r25093

This comment was imported from FlySpray: https://bugs.openttd.org/task/5486

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek