Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station preview windows have different size #5472

Closed
DorpsGek opened this issue Feb 12, 2013 · 6 comments
Closed

Station preview windows have different size #5472

DorpsGek opened this issue Feb 12, 2013 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

mb opened the ticket and wrote:

Is there a reason why the preview windows in the station building menu have different sizes? Obviously, both are being clipped to different pre-defined sizes ...

regards
Michael

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5472
@DorpsGek
Copy link
Member Author

wojteks86 wrote:

I didn't realize that it is a "problem" until now - I have exactly the same display.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5472#comment12012

@DorpsGek
Copy link
Member Author

mb wrote:

It´s in so far a "problem" because that space is wasted, i.e. it can´t be utilized by using a larger preview sprite, and it elongates that "preview list" in a senseless way. Apart from that, it looks crappy.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5472#comment12017

@DorpsGek
Copy link
Member Author

Alberth wrote:

What do you mean it cannot be utilized? In the attached file, you can see station tiles using the entire space.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5472#comment12018

@DorpsGek
Copy link
Member Author

mb wrote:

[alberth] > In the attached file, you can see station tiles using the entire space.

Yes, it´s principally possible, but

- the difference in height is quite marginal (11px). Is it really useful to have these windows differ in height, and thus have to prepare preview sprites in a special way to look "the same" in both?
- the sprite reference point in both windows is different (or even buggy?), so tiles assembled in-game (i.e. no special preview sprite) cannot be positioned properly (see preview2). Obviously, both windows try to use the bottom edge as a refernce, but in the right window, tiles are positioned 2px too low (can also be seen on the screenshot you posted).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5472#comment12021

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 4, 2013

planetmaker wrote:

Attached patch fixes the offsets and reduces the size of the rhs widgets to the one of the direction selection. I'm not sure whether we shouldn't actually increase the widget size for the direction selection, though.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5472#comment12076

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 4, 2013

planetmaker closed the ticket.

Reason for closing: Fixed

In r25064


This comment was imported from FlySpray: https://bugs.openttd.org/task/5472

@DorpsGek DorpsGek closed this as completed Mar 4, 2013
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) NewStations labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant